Feat/conf links visible #1097
Merged
Feat/conf links visible #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Conference contribution entries have a link, some not. (Most should!) The ones that do support clicking on the item to jump to it. The ones that don't have an empty link, resulting in the browser to reload the current page. Mouse over is the only way to fint out for users that I'm aware of. Change two thing: - Avoid empty links. - Add a link symbol if we do have a link. Signed-off-by: Kurt Garloff <[email protected]>
These should be rendered just as clickable link symbols below the slides link (if thhere is any, otherwise where it would otherwise be). Signed-off-by: Kurt Garloff <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
Also make it smaller. Signed-off-by: Kurt Garloff <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
Signed-off-by: Kurt Garloff <[email protected]>
fkr
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give users a visual clue when the title of the talk also is a link by adding a symbol.
Also allow for additional links (with just a link symbol).
We don't currently have information on the nature of these links, so just main link and and additional links.
This addresses #1095.
Some discussion to be found there.
This has been deployed to staging, so the visual results can be seen on
https://staging.scs.community/
in a few minutes.