Fix Visual Effects on tvOS #574
Conversation
…ound images for the normal and focused state. In addition, clear the background color of all subviews to only have the wanted background image and to fix the "unsharp" border caused by `_UIFloatingContentCornerRadiusAnimatingView`.
… keeping the rounded corners and focus effect (only affects tvOS >= 14). Background and text color are hardcoded for now since they are not included in view data from the backend.
|
Hi @andresilveirah, did you already find some time to take a look? 🙏 |
|
That's fantastic work @asshoffm . Will merge as soon the tests pass and release it at some point this week. Thank you for the PR. |
Nevazhnovu
left a comment
Nevazhnovu
left a comment
There was a problem hiding this comment.
As someone who developed the tvOS SDK, I approve since #LGTM;
I would rather have approval from @andresilveirah on this PR to proceed with merging.
.../Classes/Views/tvOS/NativePrivacyManager/GDPR/SPGDPRNativePrivacyManagerViewController.swift
Outdated
Show resolved
Hide resolved
|
Hi @andresilveirah! Is there anything I can help you with here? 🙂 The UI bugs are still present and we would be happy if this MR could be merged 🙏 |
|
Hi @andresilveirah! The GDPR category cells also fail to meet the WCAG 2.1 Contrast (Minimum) requirement, which will be an issue for us regarding the new BFSG. |
| } | ||
|
|
||
| required init?(coder: NSCoder) { | ||
| fatalError("init(coder:) has not been implemented") |
There was a problem hiding this comment.
Hey @asshoffm, could you please explain why a fatalError is thrown here? It should be avoided on the SDK by any means. This is my only concern
There was a problem hiding this comment.
Hi @Nevazhnovu! We would need this initializer when we had an XIB or storyboard for the cell. Since we create the cell only from code (or the table does when dequeuing), the initializer will never be called; by throwing a fatalError, it is clearly signaled that it shouldn't. There are several other places in the SDK where this is done the same way.
There was a problem hiding this comment.
@asshoffm I'll add @available(*, unavailable) for this init for transparency
|
@asshoffm thanks for submitting this PR! It works well with our test property. Sorry for not attending it earlier, I had strict priorities for the last few quarters... FYI @andresilveirah I've tried this PR and tvOS looks better. The changes include:
And nothing more. I've updated the branch and will merge it into the |
3 participants
Hello 👋
We now show the GDPR Privacy Manager in our tvOS app 👍🏻
There are two minor UI imperfections that we want to improve with this MR:
SPAppleTVButtonI hope the commit messages and the following screenshots provide enough information for you.