Merging latest from upstream #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change MariaDB PPA link
…le-site-installed-checks Split `is-installed` check into a non-multisite and a mulitsite specific one
Add variables for web and uploads paths
… yet set up multisite sites.
…gured-multisite Exempt from `is-installed` check the DB error dump PHP warning for not yet set up multisite sites
Limit ansible version range in `>=2.10.0,<6`
Newer versions of `ansible.builtin.git` puts error message in `msg` instead of `stderr`.
Fix ansible incompatibility with `Failed connection to remote repo`
Stop old process(es) before starting a new one. Fixes #1394 Signed-off-by: Rob Record <[email protected]>
Stop old php-fpm services before starting new one
Set max journal log file size
Use new `requirements.yml` format
Fix shared folder permissions
Use `mkpasswd` on the server instead of Ansible's `password_hash` on the host which requires the `passlib` dependency on macOS.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Simplifies complex Jinja templating logic which is brittle and breaks across Ansible versions.
This is a complicated validation for an uncommon edge case. It's also using brittle loops in jinja which is prone to break on Ansible upgrades. This was originally added in #910.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Updates the `to_env` filter to use double quotes for values instead of single quotes. This preserves literal newline character as a multiline string. Co-authored-by: Pacotole <[email protected]>
This is a complex validation that was overly defensive and mostly needed back when new OpenSSH ciphers caused more version incompatibilities in ~2016. These incompatibilities are much less likely to occur now so we can remove these validations.
NTP role will fail on its own with a helpful message:
```
TASK [ntp : Set timezone.] *****************************************************
fatal: [default]: FAILED! => {"changed": false, "msg": "Error message:\ngiven timezone \"lol_nope\" is not available"}
```
`memcached_fs_file_max` would set the `fs.file-max` (max open file descriptors) to that value. This was likely done to ensure a high number of memcached connections was possible, but the default value is high enough. Plus this is a global setting and not memcached specific.
These tasks related to creating directories are run on mounted directories for local VMs. Using `sudo` as the `become_method` can provide better guarantees that the UID/GIDs mapping are preserved properly. This might only matter for VM solutions like LXD but it shouldn't change solutions like Lima that already work correctly.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Sets ansible_python_interpreter to /usr/bin/python3 for CI tests running against localhost. This ensures Ansible uses system Python where apt-installed python3-pymysql is available, rather than the virtualenv Python which lacks MySQL libraries. * Ansible 2.19's stricter templating no longer implicitly converts string dict literals to actual dicts. Use Jinja2's dict() constructor with zip() to properly build the letsencrypt_cert_ids dictionary. * Ansible 2.19's stricter undefined handling causes errors when using 'is defined' on nested dict attributes that don't exist. Use the 'in' operator to safely check for optional keys in ssl and xmlrpc configs.
The previous solution relied on matching against ANSI control codes which was brittle. This broke (again) on Ansible 2.20 because color codes are now displayed which breaks this `intersect` substring match expression. The simpler solution is to just check for the Ansible `CHANGED` output which means the raw command and connection succeeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.