Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JIT reward #279

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix JIT reward #279

wants to merge 3 commits into from

Conversation

Philogy
Copy link
Contributor

@Philogy Philogy commented Nov 27, 2024

  • adds a reward_checksum: u80 field to the MultiTick reward variant to ensure that any JIT liquidity change reverts the bundle
  • adds the security requirement that some non-negligible amount is swapped in the end current tick, because even with the new mechanism if there is no swapping going through the final tick a reward to it could be JITed without consequences.
  • how to compute the checksum is documented under Reward Update Internals

@Philogy Philogy requested a review from gravaton November 27, 2024 11:29
@Philogy Philogy removed the request for review from gravaton December 6, 2024 05:22
@Will-Smith11
Copy link
Collaborator

Circling back here. We need this fix for launch. Lets get this merged in and going once we get the current testnet contracts working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants