SLVSCODE-972 try fix flaky autobinding test #675
+1
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophio-japharidze-sonarsource
force-pushed
the
SLVSCODE-972_fix_flaky_test
branch
from
62cf819 to
d07bb7d
Compare
| @@ -439,7 +438,7 @@ suite('Auto Binding Test Suite', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| async function deleteSettingsFiles() { | |||
There was a problem hiding this comment.
the temporary settings files need to be deleted not to pollute the state for upcoming test suites. At the same time, binding needs to be cleaned up after each test.
Possibly there used to be a race condition between the two actions. This change aims to mitigate this.
|
jblievremont
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVSCODE-972