Skip to content

BUILD-9108 warp windows oss #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

BUILD-9108 warp windows oss #115

merged 1 commit into from
Nov 4, 2025

Conversation

@julien-carsique-sonarsource
Copy link
Contributor

@julien-carsique-sonarsource julien-carsique-sonarsource commented Oct 3, 2025 •
edited
Loading

@julien-carsique-sonarsource julien-carsique-sonarsource force-pushed the fix/jcarsique/BUILD-9108-windowsRunner branch 3 times, most recently from 857bf88 to 418c2f1 Compare October 10, 2025 13:00
@julien-carsique-sonarsource julien-carsique-sonarsource force-pushed the fix/jcarsique/BUILD-9108-windowsRunner branch 3 times, most recently from 0b68ccc to 588ffa3 Compare November 3, 2025 13:17
@julien-carsique-sonarsource julien-carsique-sonarsource mentioned this pull request Nov 3, 2025
Merged
@julien-carsique-sonarsource julien-carsique-sonarsource force-pushed the fix/jcarsique/BUILD-9108-windowsRunner branch from 588ffa3 to 191b781 Compare November 3, 2025 14:37
@julien-carsique-sonarsource julien-carsique-sonarsource marked this pull request as ready for review November 3, 2025 14:47
@julien-carsique-sonarsource julien-carsique-sonarsource requested a review from a team as a code owner November 3, 2025 14:47
tomverin
tomverin approved these changes Nov 4, 2025
View reviewed changes
@julien-carsique-sonarsource
BUILD-9108 fix build-gradle for Windows
b418616 
use /bin/usr/find in build-gradle for compatibility with Windows Bash
use local cache action in build-gradle
@julien-carsique-sonarsource julien-carsique-sonarsource force-pushed the fix/jcarsique/BUILD-9108-windowsRunner branch from 191b781 to b418616 Compare November 4, 2025 08:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2025

SonarQube reviewer guide

Summary: Updates build-gradle action to use local cache action and improves shell scripting practices.

Review Focus: Cache action replacement from external to local symlink, cache key generation logic changes (removed sort operation), and shell variable assignment pattern change.

Start review at: build-gradle/action.yml. This contains the core functionality changes including the cache action replacement and modified cache key generation logic that could impact build reproducibility.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 Dependency risks

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@julien-carsique-sonarsource julien-carsique-sonarsource merged commit b2aa967 into master Nov 4, 2025
11 checks passed
@julien-carsique-sonarsource julien-carsique-sonarsource deleted the fix/jcarsique/BUILD-9108-windowsRunner branch November 4, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomverin tomverin tomverin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@julien-carsique-sonarsource @tomverin