Remove dependency on Half #21
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the dependency on
Half
, which is currently used to provide a half-precision floating point type.Float16
was introduced with Swift 5.3, so the dependency is no longer needed.Checklist
Ensure that your
pull request
has followed all the steps below:Proposed changes
The main changes are:
Float16
type insteadMinor changes are:
if-else
statementsAdditional Info
The dependency on
Float16
requires higher minimum deployment targets on all platforms:9.0
->14.0
10.10
->11.0
9.0
->14.0
2.0
->7.0
For systems with swift version lower than
5.3
, the dependency on Half is still needed. In this case thetypealias Float16 = Half
is included. The package descriptions for4.2
and5.0
still include the dependency. The correct compilation on older platforms is untested.