[REFERENCE ONLY DO NOT REVIEW!!!] Implement Mojang WebAPI, common user root class, and playerheads #56
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,8 @@ plugins { | |
| id "com.github.hierynomus.license" version "0.15.0" | ||
| } | ||
|
|
||
|
|
||
|
|
||
| jacoco { | ||
| // Use JaCoCo 0.8.6 for (experimental) support for Java 15 class files. | ||
| toolVersion = "0.8.6" | ||
|
|
@@ -25,6 +27,7 @@ license { | |
| tasks.withType(JavaCompile) { | ||
| options.compilerArgs << "-Xlint:unchecked" << "-Xlint:deprecation" << "-XDignore.symbol.file" | ||
| } | ||
|
|
||
| // Run the license formatter before compiling the source code. | ||
| tasks.compileJava.dependsOn licenseFormatMain, licenseFormatTest | ||
|
|
||
|
|
@@ -37,6 +40,7 @@ configurations { | |
| repositories { | ||
| mavenCentral() | ||
| jcenter() | ||
| google() | ||
|
|
||
| maven { url 'https://oss.sonatype.org/content/repositories/snapshots' } | ||
| maven { url 'https://papermc.io/repo/repository/maven-public/' } | ||
|
|
@@ -48,30 +52,38 @@ dependencies { | |
|
|
||
| compileOnly 'com.destroystokyo.paper:paper-api:1.16.4-R0.1-SNAPSHOT' | ||
| compileOnly 'net.md-5:bungeecord-api:1.16-R0.4-SNAPSHOT' | ||
|
|
||
| implementation 'org.jetbrains:annotations:20.1.0' | ||
| implementation 'com.google.code.gson:gson:2.8.6' | ||
| implementation 'io.github.classgraph:classgraph:4.8.98' | ||
| implementation 'com.github.seancfoley:ipaddress:5.3.3' | ||
| implementation 'com.squareup.okhttp3:okhttp:4.9.0' | ||
| implementation 'commons-validator:commons-validator:1.7' | ||
|
Collaborator
There was a problem hiding this comment. Please use Guava's preconditions rather than shading in deps to StickyAPI.
Collaborator
There was a problem hiding this comment. See the JavaDocs for preconditions. This is included in both bukkit and bungee so will work at runtime. No need to shade in extra dependencies.
Collaborator
There was a problem hiding this comment. Unless you're intending to use this for a completely different reason.
Collaborator
Author
There was a problem hiding this comment. Validator is used primarily to check url formatting for validity, and determine if a URL is validly formatted (and I think it also checks if it's resolvable). There are a couple other ways I plan to use it.
Collaborator
Author
There was a problem hiding this comment. We can also theoretically call the minimize() function to reduce jar size
Collaborator
There was a problem hiding this comment.
Google preconditions does thissssss - just include a URL regex.
Collaborator
There was a problem hiding this comment.
This has side effects, we've already tried it.
Collaborator
There was a problem hiding this comment. Do we even need to validate the URL ourselves? OkHttp should throw an exception when unable to parse a URL, and if we don't want to use OkHttp, a regular expression will do for URL validity
Collaborator
There was a problem hiding this comment. We could also probably test URL validity by attempting to construct a URL object using the string and seeing if a MalformedURLException is thrown |
||
| implementation 'com.google.guava:guava:30.1-jre' | ||
|
|
||
| // JUnit 5 Testing | ||
| testImplementation 'org.junit.jupiter:junit-jupiter-api:5.7.0' | ||
| testRuntimeOnly 'org.junit.jupiter:junit-jupiter-engine:5.7.0' | ||
|
|
||
| // Mocking | ||
| testImplementation("org.powermock:powermock-module-junit4:2.0.9") | ||
| testImplementation("org.powermock:powermock-api-mockito2:2.0.9") | ||
| testImplementation("org.powermock:powermock-module-junit4-rule:2.0.9") | ||
| testImplementation("org.powermock:powermock-classloading-xstream:2.0.9") | ||
| testImplementation("org.mockito:mockito-core:3.7.0") | ||
| testImplementation 'com.github.seeseemelk:MockBukkit-v1.16:0.5.0' | ||
| testImplementation 'it.unimi.dsi:fastutil:8.4.4' | ||
|
||
| } | ||
|
|
||
|
|
||
| test { | ||
| useJUnitPlatform() | ||
| testLogging { | ||
| events "passed", "skipped", "failed" | ||
| // Show System.out for code ran by tests | ||
| showStandardStreams = true | ||
| } | ||
| //ignoreFailures = true | ||
|
Member
There was a problem hiding this comment. remove this line if it's commented.
Collaborator
Author
There was a problem hiding this comment. Its there for testing. I will try to fold into a new task |
||
| finalizedBy jacocoTestReport // report is always generated after tests run | ||
| } | ||
|
|
||
|
|
@@ -88,9 +100,44 @@ task sources(type: Jar, dependsOn: classes) { | |
| from sourceSets.main.allSource | ||
| } | ||
|
|
||
| tasks.delombok.shouldRunAfter(sources) | ||
| tasks.publish.dependsOn build | ||
| tasks.build.shouldRunAfter(clean) | ||
| tasks.javadoc.shouldRunAfter(clean) | ||
|
Member
There was a problem hiding this comment. I'm a little hesitant to have javadoc and build run after clean... @NotZachery thoughts?
Member
There was a problem hiding this comment. I don't see how this could become an issue so I'm fine by it.
Collaborator
Author
There was a problem hiding this comment. They are set to run after as should, not forced. This prevents (if you did, say, |
||
| tasks.build.finalizedBy(sources) | ||
|
|
||
| delombok { | ||
| finalizedBy(javadoc) | ||
| print(true) | ||
| //verbose(true) | ||
| } | ||
|
|
||
| tasks.withType(JavaCompile) { | ||
| options.encoding = "UTF-8" | ||
| } | ||
| tasks.withType(Test) { | ||
| systemProperty "file.encoding", "UTF-8" | ||
| } | ||
|
|
||
| javadoc { | ||
| options.addBooleanOption('XDignore.symbol.file', true) | ||
| options.addBooleanOption('-frames', true) | ||
| options.addBooleanOption('private', true) | ||
| test.ignoreFailures true; | ||
| options.encoding = 'UTF-8' | ||
| dependsOn delombok | ||
| } | ||
|
|
||
| task browseJavadoc { | ||
| dependsOn javadoc | ||
| doLast { | ||
| java.awt.Desktop.desktop.browse new URI(("file:///" << System.getProperty("user.dir").replace('\\','/') << "/build/docs/javadoc/index.html").toString()) | ||
| } | ||
| } | ||
|
|
||
| task rebuild { | ||
| dependsOn build, clean | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1 @@ | ||||||||
| systemProp.file.encoding=utf-8 | ||||||||
|
Collaborator
There was a problem hiding this comment.
Suggested change
|
||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-bin.zip | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,23 @@ | ||
| /* | ||
| * Copyright (c) 2021 DumbDogDiner <dumbdogdiner.com>. All rights reserved. | ||
| * Licensed under the MIT license, see LICENSE for more information... | ||
| */ | ||
| package com.dumbdogdiner.stickyapi.bukkit.generator; | ||
|
|
||
| import org.bukkit.World; | ||
| import org.bukkit.generator.ChunkGenerator; | ||
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| import java.util.Random; | ||
|
|
||
| /** | ||
| * A class for generating empty void worlds | ||
| */ | ||
| @SuppressWarnings("unused") | ||
| public class VoidGenerator extends ChunkGenerator { | ||
|
|
||
| @Override | ||
| public @NotNull ChunkData generateChunkData(@NotNull World world, @NotNull Random random, int x, int z, @NotNull BiomeGrid biome) { | ||
| return createChunkData(world); | ||
| } | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.