Skip to content

Conversation

@rjmunro
Copy link
Contributor

@rjmunro rjmunro commented Nov 20, 2025

About the Contributor

This pull request is posted on behalf of myself

Type of Contribution

This is a Feature

Current Behavior

The defaults for "Take" are "F12" and "Numpad Enter", both fairly obscure keys. Many laptop keyboards don't feature either of them, at least not without use of the Fn modifier key. If the show goes straight to plan, it's literally the only key that you need, so it should be more obvious.

New Behavior

Pressing space Takes the next item.

F12 and Numpad Enter still work. You can still remove space in settings if you need to.

Testing

  • Setup Sofie so that all settings are default
  • Start a rundown
  • Press space

It should take the next part.

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects a default setting.

Time Frame

  • Not urgent, but we would like to get this merged into the in-development release.

Other Information

This has annoyed me for ages.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

F12 and Numpad Enter still work. You can still remove space in settings
if you need to.
@rjmunro rjmunro requested a review from a team as a code owner November 20, 2025 15:04
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@PeterC89
Copy link
Contributor

Personally not against this but you could add it via the triggeredActions property in the System config?

triggeredActions: IBlueprintTriggeredActions[]

@nytamin nytamin self-requested a review November 21, 2025 06:19
@RannveigNC
Copy link

Hi,

I see no reason as to why this feature should't be added, as long as we’re able to opt out at NRK.

Kind Regards
Rannveig Carlsen
UX-designer Sofie at NRK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants