-
Notifications
You must be signed in to change notification settings - Fork 55
chore: refactor lsg asyncapi schema #1543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justandras
wants to merge
35
commits into
Sofie-Automation:release53
Choose a base branch
from
SuperFlyTV:chore/refactor-lsg-asyncapi-schema
base: release53
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: refactor lsg asyncapi schema #1543
justandras
wants to merge
35
commits into
Sofie-Automation:release53
from
SuperFlyTV:chore/refactor-lsg-asyncapi-schema
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
f6e3a3c to
a47be7b
Compare
a47be7b to
82d6afc
Compare
7 tasks
ianshade
reviewed
Nov 3, 2025
packages/live-status-gateway-api/scripts/resolve-nested-examples.mjs
Outdated
Show resolved
Hide resolved
ianshade
approved these changes
Nov 21, 2025
Contributor
ianshade
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, and tested some of it locally. I'm happy with the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC.
Type of Contribution
This is a: Code improvement / Documentation improvement
Current Behavior
/channelNew Behavior
asyncapi.yamlfile for better compatibility with tools like Postman and other parsers.Testing
Affected areas
This PR is only an internal refactor of the schemas, there is no breaking change in the generated types.
This PR affects:
Time Frame
This Refactor is critical for us, we have other PRs, feature request that depend on it.
Other Information
Due to AsyncApi limitations, some types now have to have an optional property
additionalProperties. This will remain unused, there is no clean workaround to have inheritance between schemas that we know of and disallowadditionalPropertiesat the same time.We the SuperFly team have discussed it internally and feel like it's a worthy compromise.
Status