Repository navigation
fix: prevent unwanted files getting into app.asar - #33
Conversation
app.asar included binaries that it should never contain, because the electron-builder output dir was shared with where the app code goes (dist); this change cuts down the installer and installed app size by about half (at least on Windows)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR configures Electron Builder to output build artifacts to a ChangesBuild output directory configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
About the Contributor
This pull request is posted on behalf of TV 2 Norge
Type of Contribution
This is a:
Build configuration fix
Current Behavior
app.asar contained binaries and other files that it should never contain, because the electron-builder output dir was shared with where the built app code goes (
dist)New Behavior
this change cuts down the installer and installed app size each by about half (at least on Windows), by changing the output directory for electron to
releaseTesting Instructions
Other Information
Status