Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix load_nids to filter rows with two elements #76

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PliskinDev
Copy link

modified load_nids to filter rows with exactly two elements.
prevents ValueError during CSV processing, improving stability and correctness of NID loading.

Screenshot 2024-10-01 014414

@SocraticBliss
Copy link
Owner

While I completely agree that loading in an invalid file could (should?) be handled better, if we were to go to this level of checking, we should probably let the user know that the file that they have provided is invalid due to them adding another column.

Regardless, the principle is sound, I will add some additional logic there and give you the proper credit :)

Then I'll close out this when it is implemented.

Thanks again for submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants