fix: update footer description (#2934)#3083
Closed
LucasCharrier wants to merge 43 commits intoalphafrom
Closed
Conversation
* fix(redis): retrieve chart locally * fix: use bitnamilegacy * fix: it --------- Co-authored-by: Gary van Woerkens <gary.van-woerkens@sg.social.gouv.fr>
Comment out the entire dependabot configuration.
* feat: utilisation de l'api annuaire entreprise * fix: typage * fix: error staff declaration * fix: memoize * dummy commit * fix: gestion des entreprises non diffusible * fix: NAF non diffusible * fix NAF non diffusible * fix: naf non diffusible * separate label country
* Ouverture des déclarations 2026 * modification texte oage aide-index * fix: saut à la ligne entre adresse et siren dans le recap
Co-authored-by: Gary van Woerkens <gary.van-woerkens@sg.social.gouv.fr>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Gary van Woerkens <gary.van-woerkens@sg.social.gouv.fr>
Removed 'moncomptepro' secret reference from values.yaml.
Replace "développés et maintenus par les équipes de la fabrique numérique" with a user-facing description of what Egapro does. Closes #2934
revu-bot
reviewed
Mar 25, 2026
Collaborator
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
PR Review: Update Footer Description
This is a straightforward copy/text change replacing the old "développés et maintenus par les équipes de la fabrique numérique des ministères sociaux" description with a product-focused description.
| File | Lines | Severity | Issue | Action |
|---|---|---|---|---|
packages/app/src/app/Footer.tsx |
132–133 | MINOR | Description omits "Index Egapro" and "Représentation équilibrée" product names | Consider mentioning both products |
packages/app/src/app/Footer.tsx |
132–133 | MINOR | No test coverage for footer text change | Add/update snapshot or text assertion test |
The change is functionally correct and addresses the issue. Two minor observations are noted below.
LucasCharrier
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
LucasCharrier
had a problem deploying
to
build-review-auto
GitHub Actions
Error
LucasCharrier
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
LucasCharrier
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
LucasCharrier
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
LucasCharrier
temporarily deployed
to
review-auto
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2934