Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log topic on ethereum side #1404

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Log topic on ethereum side #1404

merged 3 commits into from
Mar 7, 2025

Conversation

vgeddes
Copy link
Collaborator

@vgeddes vgeddes commented Mar 6, 2025

We missed this.

Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yrong
Copy link
Contributor

yrong commented Mar 7, 2025

Some tests failed

forge test --match-test testSubmitRegisterPNA -vvvv

which requires test fixture from local setup.

@vgeddes You can leave it to me, I'll update the relayer and the text fixture.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v2@e4af25d). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1404   +/-   ##
=====================================
  Coverage      ?   78.73%           
=====================================
  Files         ?       23           
  Lines         ?      884           
  Branches      ?      133           
=====================================
  Hits          ?      696           
  Misses        ?      163           
  Partials      ?       25           
Flag Coverage Δ
solidity 78.73% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yrong
Copy link
Contributor

yrong commented Mar 7, 2025

Tested this PR alongside vgeddes/polkadot-sdk#35 using a local setup. The outbound smoke test works as expected.

I think we can merge these two PRs now.

@vgeddes vgeddes merged commit 76057a2 into v2 Mar 7, 2025
3 checks passed
@vgeddes vgeddes deleted the log-topic branch March 7, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants