-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log topic on ethereum side #1404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Some tests failed
which requires test fixture from local setup. @vgeddes You can leave it to me, I'll update the relayer and the text fixture. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #1404 +/- ##
=====================================
Coverage ? 78.73%
=====================================
Files ? 23
Lines ? 884
Branches ? 133
=====================================
Hits ? 696
Misses ? 163
Partials ? 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tested this PR alongside vgeddes/polkadot-sdk#35 using a local setup. The outbound smoke test works as expected. I think we can merge these two PRs now. |
We missed this.