Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve smoke tests #1396

Merged
merged 13 commits into from
Mar 4, 2025
Merged

Improve smoke tests #1396

merged 13 commits into from
Mar 4, 2025

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Feb 28, 2025

Base automatically changed from register-token to v2 February 28, 2025 16:16
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v2@6936241). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1396   +/-   ##
=====================================
  Coverage      ?   73.16%           
=====================================
  Files         ?       23           
  Lines         ?      898           
  Branches      ?      135           
=====================================
  Hits          ?      657           
  Misses        ?      221           
  Partials      ?       20           
Flag Coverage Δ
solidity 73.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yrong yrong marked this pull request as ready for review March 3, 2025 02:45
@yrong yrong requested a review from claravanstaden March 3, 2025 03:44
Copy link
Contributor

@claravanstaden claravanstaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🥳

@yrong yrong merged commit 53db204 into v2 Mar 4, 2025
2 checks passed
@yrong yrong deleted the ron/improve-smoke-tests branch March 4, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants