Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway should no longer build token registration XCM #1381

Merged
merged 9 commits into from
Feb 28, 2025
Merged

Conversation

vgeddes
Copy link
Collaborator

@vgeddes vgeddes commented Feb 12, 2025

Instead, I've modified the protocol so that:

  1. Users can still pass raw xcm blobs
  2. The gateway itself can pass a "template id" like CreateAssetXCM of raw xcm.

Then the inbound-queue on BH can either passthrough the raw xcm or build the create asset XCM.

@yrong
Copy link
Contributor

yrong commented Feb 28, 2025

@vgeddes @claravanstaden Since we've already merged vgeddes/polkadot-sdk#13, we may also need to merge this PR to V2 to pass the smoke tests.

I've resolved the conflicts in recent commits, Let me know if we need any further tweaks!

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2@7b0d54e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
contracts/src/Gateway.sol 0.00% 1 Missing ⚠️
contracts/src/v2/Calls.sol 50.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1381   +/-   ##
=====================================
  Coverage      ?   73.16%           
=====================================
  Files         ?       23           
  Lines         ?      898           
  Branches      ?      135           
=====================================
  Hits          ?      657           
  Misses        ?      221           
  Partials      ?       20           
Flag Coverage Δ
solidity 73.16% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgeddes vgeddes merged commit 6936241 into v2 Feb 28, 2025
3 checks passed
@vgeddes vgeddes deleted the register-token branch February 28, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants