Feature #3038 Use display_pattern on product view, product compare pages#3047
Closed
rbayet wants to merge 1 commit intoSmile-SA:2.11.xfrom
Closed
Feature #3038 Use display_pattern on product view, product compare pages#3047rbayet wants to merge 1 commit intoSmile-SA:2.11.xfrom
rbayet wants to merge 1 commit intoSmile-SA:2.11.xfrom
Conversation
…mpare pages (disabled by default)
Collaborator
Author
|
Hello @ecrocombe, Actually, testing the feature locally, I think it needs a bit more polish : the precision is actually not taken into account at all. It seems that the slider cheats by systematically using the JS price formatter because the locale oriented PHP classes of Magento2 Framework does not seem to really care about it (hence probably because you went for "round"). So I'll try to figure out a way to correctly have the value formatted exactly like in the slider. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(disabled by default)