Skip to content

Matter Switch: Lazy load subdrivers if possible #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickolas-deboom merged 1 commit into from
Dec 4, 2025
Merged

Matter Switch: Lazy load subdrivers if possible #2525

nickolas-deboom merged 1 commit into from
Dec 4, 2025

Conversation

@nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Nov 4, 2025

This change utilizes the new lazy_load_sub_driver_v2 api to lazy load subdrivers in the matter switch driver.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025 •
edited
Loading

Channel deleted.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025 •
edited
Loading

Test Results

   71 files    477 suites   0s ⏱️
2 471 tests 2 471 ✅ 0 💤 0 ❌
4 236 runs  4 236 ✅ 0 💤 0 ❌

Results for commit 69e20ee.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025 •
edited
Loading

File Coverage
All files 92% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/eve_energy/init.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/fields.lua 99% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/utils.lua 90% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_utils/embedded_cluster_utils.lua 38% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_utils/device_configuration.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_utils/utils.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/attribute_handlers.lua 84% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/event_handlers.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/switch_handlers/capability_handlers.lua 88% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/ikea_scroll/init.lua 85% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/third_reality_mk1/init.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/aqara_cube/init.lua 96% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_handlers/capability_handlers.lua 78% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/sub_drivers/camera/camera_handlers/attribute_handlers.lua 95% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 69e20ee

@nickolas-deboom nickolas-deboom mentioned this pull request Nov 4, 2025
Merged
12 tasks
@cjswedes cjswedes mentioned this pull request Nov 5, 2025
Closed
cjswedes
cjswedes approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@cjswedes cjswedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the copywrite on all the files? Its nice to get that done when there are actual code changes for a driver in a release cycle. You can do in a follow up PR too, if you get it in this release cycle.

@hcarter-775
Copy link
Contributor

hcarter-775 commented Nov 5, 2025

Also, with the PR I just merged, the switch_utils file now has a different name and is in a different directory (thus a conflict). Should be a simple fix, but I'm not sure how nicely git rebase will understand this change. Maybe well

@cjswedes
Copy link
Contributor

cjswedes commented Nov 5, 2025 •
edited
Loading

Please make sure tests are run against 59 58 lua libs locally before merging to exercise these changes with lazy_load_sub_driver_v2. edit: to 58 since now 59 is what is being used as the latest release, but we need to check tests on both.

@nickolas-deboom nickolas-deboom mentioned this pull request Nov 17, 2025
Merged
@aleclorimer
Copy link
Contributor

aleclorimer commented Nov 19, 2025

What is the plan/status of this?

@nickolas-deboom
Copy link
Contributor Author

nickolas-deboom commented Nov 24, 2025

What is the plan/status of this?

This will most likely land this week.

@nickolas-deboom
Copy link
Contributor Author

nickolas-deboom commented Nov 24, 2025

Can you update the copywrite on all the files? Its nice to get that done when there are actual code changes for a driver in a release cycle. You can do in a follow up PR too, if you get it in this release cycle.

Sure thing. Should the dates be updated to 2025 or left as they are? I've heard conflicting direction on that so not too sure

@hcarter-775
Copy link
Contributor

hcarter-775 commented Nov 24, 2025

@nickolas-deboom I'd say leave the year as-is. However in this case I think all the files are already 2025

@aleclorimer
Copy link
Contributor

aleclorimer commented Dec 2, 2025

Can you update the copywrite on all the files? Its nice to get that done when there are actual code changes for a driver in a release cycle. You can do in a follow up PR too, if you get it in this release cycle.

Sure thing. Should the dates be updated to 2025 or left as they are? I've heard conflicting direction on that so not too sure

What I've been told and have been doing is updating everything to the newer shorter copyright notice. I think we should go for that

@nickolas-deboom nickolas-deboom force-pushed the matter-switch-lazy-loading-for-subdrivers branch 3 times, most recently from a9e8841 to 603a2ae Compare December 3, 2025 17:59
@nickolas-deboom
Copy link
Contributor Author

nickolas-deboom commented Dec 3, 2025

Please make sure tests are run against 59 58 lua libs locally before merging to exercise these changes with lazy_load_sub_driver_v2. edit: to 58 since now 59 is what is being used as the latest release, but we need to check tests on both.

I checked on 58 and everything passes except for the camera tests, since they use clusters not available below 59.

@nickolas-deboom nickolas-deboom force-pushed the matter-switch-lazy-loading-for-subdrivers branch from 603a2ae to 757b393 Compare December 3, 2025 18:02
gharveymn
gharveymn approved these changes Dec 3, 2025
View reviewed changes
drivers/SmartThings/matter-switch/src/init.lua
sub_drivers = {
require("sub_drivers.aqara_cube"),
switch_utils.lazy_load_if_possible("sub_drivers.aqara_cube"),
switch_utils.lazy_load("sub_drivers.camera"),
Copy link
Contributor

@gharveymn gharveymn Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one can't use lazy_load_if_possible?

Copy link
Contributor Author

@nickolas-deboom nickolas-deboom Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't, because it's not supported at all for lower lua libs versions, rather only supported for 16 and above where lazy_load_sub_driver_v2 is available

@nickolas-deboom nickolas-deboom force-pushed the matter-switch-lazy-loading-for-subdrivers branch from 757b393 to 1a398d2 Compare December 3, 2025 22:00
@nickolas-deboom
Copy link
Contributor Author

nickolas-deboom commented Dec 3, 2025

FYI I rebased following the changes from #2579, and so in the latest force push I added lazy loading for the bilresa subdriver.

@nickolas-deboom
Matter Switch: Lazy load subdrivers if possible
69e20ee 
This change utilizes the new `lazy_load_sub_driver_v2` api to lazy load
subdrivers.
@nickolas-deboom nickolas-deboom force-pushed the matter-switch-lazy-loading-for-subdrivers branch from 1a398d2 to 69e20ee Compare December 3, 2025 22:04
@nickolas-deboom nickolas-deboom merged commit 63158a5 into main Dec 4, 2025
11 checks passed
@nickolas-deboom nickolas-deboom deleted the matter-switch-lazy-loading-for-subdrivers branch December 4, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gharveymn gharveymn gharveymn approved these changes

@cjswedes cjswedes cjswedes approved these changes

@hcarter-775 hcarter-775 hcarter-775 approved these changes

@ctowns ctowns Awaiting requested review from ctowns

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nickolas-deboom @hcarter-775 @cjswedes @aleclorimer @gharveymn