Matter Switch: Add switch-fan profile #2514
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 477 suites 0s ⏱️ Results for commit 3207196. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3207196 |
hcarter-775
force-pushed
the
add-switch-fan
branch
from
2aa9869 to
a809b47
Compare
hcarter-775
force-pushed
the
add-switch-fan
branch
2 times, most recently
from
28a9a6d to
73edaae
Compare
ctowns
reviewed
Dec 3, 2025
| - id: refresh | ||
| version: 1 | ||
| categories: | ||
| - name: Switch |
Contributor
There was a problem hiding this comment.
Why are we using the Switch if this could also be a light? Just want to make sure we don't get pinged about this later. And why not use Fan instead?
hcarter-775
force-pushed
the
add-switch-fan
branch
from
73edaae to
3207196
Compare
ctowns
approved these changes
Dec 4, 2025
Contributor
ctowns
left a comment
ctowns
left a comment
There was a problem hiding this comment.
Looks good, let's have a discussion offline about the category selection, but that can also be changed later if needed.
nickolas-deboom
approved these changes
Dec 4, 2025
| updated_profile = SwitchDeviceConfiguration.assign_profile_for_onoff_ep(device, default_endpoint_id) | ||
| local generic_profile = function(s) return string.find(updated_profile or "", s, 1, true) end | ||
| if generic_profile("light-color-level") and #device:get_endpoints(clusters.FanControl.ID) > 0 then | ||
| if (generic_profile("plug-binary") or generic_profile("light-binary")) and #device:get_endpoints(clusters.FanControl.ID) > 0 then |
Contributor
There was a problem hiding this comment.
Similar to Cooper's comment, should we split this up and have a separate light-fan profile with the Light category?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add new profile. Generically choose it always whether the device is a plug or a light binary device.
Summary of Completed Tests
Added a test case to show correct update logic.