Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/mattermost/mattermost-server/v5 from 5.32.1 to 5.33.0 in /dependabot #104

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps github.com/mattermost/mattermost-server/v5 from 5.32.1 to 5.33.0.

Release notes

Sourced from github.com/mattermost/mattermost-server/v5's releases.

v5.33.0

Mattermost Platform Release v5.33.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Mar 18, 2021
@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Mattermost now needs go 1.15 minimum, but 1.14 is all that's available
in buster apt sources, so grab a specific version ourselves to use.

This is untested and a little rickety, but let's see what happens.
@parnic-sks
Copy link
Collaborator

Not real sure how to proceed from here. The custom Go version worked for most configurations, but seems to have caused problems for others. I assume there's a better solution.

@dependabot-preview
Copy link
Contributor Author

A newer version of github.com/mattermost/mattermost-server/v5 exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@parnic-sks parnic-sks merged commit d9d94c2 into master Mar 23, 2021
@parnic-sks parnic-sks deleted the dependabot/go_modules/dependabot/master/github.com/mattermost/mattermost-server/v5-5.33.0 branch March 23, 2021 17:21
@parnic-sks
Copy link
Collaborator

parnic-sks commented Mar 24, 2021

Looking into the specific configuration failures further, it seems to be the fault of a new dependency added in 5.33.0, https://github.com/mailru/easygo . Presumably taking this PR would fix it, so I wonder if it's worth trying to patch mattermost's go.mod/go.sum to point at this PR's source branch or similar.

edit: Mattermost is going to fix it, so we can restore the other configurations in 5.33.2: mattermost/mattermost#17213

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

1 participant