Skip to content

triv: preserve backslashes in strings to handle json values #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
Merged

triv: preserve backslashes in strings to handle json values #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ObjectSerializer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public static function setDateTimeFormat($format)

public static function removeSpecialCharacters($string)
{
return preg_replace('/[<>`|\\\\]/', '', $string);
return preg_replace('/[<>`|]/', '', $string);
}

/**
Expand Down
44 changes: 39 additions & 5 deletions tests/tests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ private function getPaymentPayloadRequiredFieldsOnly(
]),
]);
$userData = new UserData([
"first_name" => "|Jan\ko|",
"last_name" => "<Hraško>\\`",
"first_name" => "|Janko|",
"last_name" => "<Hraško>`",
"email" => "[email protected]",
]);
$bankTransfer = new BankTransfer();
Expand Down Expand Up @@ -164,14 +164,14 @@ private function getPaymentPayload(
]);

$userData = new UserData([
"first_name" => "|Jan\ko|",
"last_name" => "<Hraško>\\`",
"first_name" => "|Janko|",
"last_name" => "<Hraško>`",
"email" => "[email protected]",
]);

$bankTransfer = new BankTransfer();
$billingAddress = new Address([
"street_name" => "<Test|\Street",
"street_name" => "<Test|Street",
"building_number" => "12",
"town_name" => "T<ow>n",
"post_code" => "97405",
Expand Down Expand Up @@ -740,6 +740,40 @@ public function testLoanPrecalculation()
$first_offer = $response_list[0];
$this->assertTrue(! is_null($first_offer->getLoanInterestRate()));
}

public function testRemoveSpecialCharacters()
{
$this->assertEquals('helloworld', ObjectSerializer::removeSpecialCharacters('hello<world'));
$this->assertEquals('helloworld', ObjectSerializer::removeSpecialCharacters('h<e>l`l|o<w>o|r`ld'));
$this->assertEquals('hello\"world', ObjectSerializer::removeSpecialCharacters('hello\"world'));
$this->assertEquals('hello\\nworld', ObjectSerializer::removeSpecialCharacters('hello\\nworld'));
$this->assertEquals('hello\\\\world', ObjectSerializer::removeSpecialCharacters('hello\\\\world'));
$this->assertEquals('', ObjectSerializer::removeSpecialCharacters('<>`|'));
$this->assertEquals('', ObjectSerializer::removeSpecialCharacters(''));
$this->assertEquals('normalstring', ObjectSerializer::removeSpecialCharacters('normalstring'));
$this->assertEquals('test\\data', ObjectSerializer::removeSpecialCharacters('test<\\>data'));
$this->assertEquals('path\\file', ObjectSerializer::removeSpecialCharacters('path|\\|file'));
$this->assertEquals('code\\function', ObjectSerializer::removeSpecialCharacters('code`\\`function'));

$input = '..."protocolVersion":"ECv1","signedMessage":"{\"encryptedMessage\"...';
$expected = '..."protocolVersion":"ECv1","signedMessage":"{\"encryptedMessage\"...';
$this->assertEquals($expected, ObjectSerializer::removeSpecialCharacters($input));

$input = '...\"protocolVersion\":\"ECv1\",\"signedMessage\":\"{\\\"encryptedMessage\\\"...';
$expected = '...\"protocolVersion\":\"ECv1\",\"signedMessage\":\"{\\\"encryptedMessage\\\"...';
$this->assertEquals($expected, ObjectSerializer::removeSpecialCharacters($input));

$jsonInput = '{"name":"John \"Doe\"","message":"Hello\\nWorld","path":"C:\\\\Users\\\\test"}';
$expectedJson = '{"name":"John \"Doe\"","message":"Hello\\nWorld","path":"C:\\\\Users\\\\test"}';
$this->assertEquals($expectedJson, ObjectSerializer::removeSpecialCharacters($jsonInput));

$googlePayInput = '{"protocolVersion":"ECv1","signedMessage":"{\"encryptedMessage\":\"data\",\"tag\":\"signature\"}"}';
$this->assertEquals($googlePayInput, ObjectSerializer::removeSpecialCharacters($googlePayInput));

$mixedInput = 'hello<world>\"test\"|value`more\\n';
$expectedMixed = 'helloworld\"test\\"valuemore\\n';
$this->assertEquals($expectedMixed, ObjectSerializer::removeSpecialCharacters($mixedInput));
}
}

function mock_addAuthHeader($headers)
Expand Down