feat(Jobs): Allow to configure Schedules in kubernetes job configuration#250
Conversation
Signed-off-by: David Majorczyk <jan.nachtingal@gmail.com>
Signed-off-by: David Majorczyk <jan.nachtingal@gmail.com>
|
@Silthian did you manage to test it? |
Nope, try to test with podman desktop and minikube but got some errors on slimfaas pods. @guillaume-chervet : I test it and it's OK |
demo/deployment-cron.yaml
Outdated
| SlimFaas/DefaultVisibility: "Public" | ||
| SlimFaas/NumberParallelJob: "1" | ||
| SlimFaas/DependsOn: "fibonacci1,fibonacci2" | ||
| SlimFaas/Schedules: '[{"Schedule":"0 0 * * *","Args":[]}]' |
There was a problem hiding this comment.
SlimFaas/Schedules: '[{"Schedule":"0/2 0 * * *","Args":["39"]}]' would be better
There was a problem hiding this comment.
Change to 0/2 * * * * (every 2 minutes).
Update the jobs.md doc to reflect it.
There was a problem hiding this comment.
Change to */2 * * * * (every 2 minutes) as internal cron parser considers 0/2 * * * * as 0 * * * *
Also update the documentation.
Signed-off-by: David Majorczyk <jan.nachtingal@gmail.com>
|
let discuss it in minutes slimfaas :) |
Signed-off-by: David Majorczyk <jan.nachtingal@gmail.com>
There si still an error image_not_allowed when enqueuing the job. |
Signed-off-by: David Majorczyk <jan.nachtingal@gmail.com>
…onfiguration' into feature/configure-schedules-in-configuration
|
Unit test seems to fail @Silthian |
Signed-off-by: David Majorczyk <jan.nachtingal@gmail.com>
|
sorry, fix the old test and a new one to check that image is added to whitelist if not present |
2 participants
#247