Skip to content

[Security] Fix HIGH vulnerability: python.lang.security.audit.eval-detected.eval-detected #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Security] Fix HIGH vulnerability: python.lang.security.audit.eval-detected.eval-detected #4031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions skyvern/services/script_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1707,11 +1707,17 @@ def render_template(template: str, data: dict[str, Any] | None = None) -> str:

def render_list(template: str, data: dict[str, Any] | None = None) -> list[str]:
rendered_value = render_template(template, data)
list_value = eval(rendered_value)
if isinstance(list_value, list):
return list_value
else:
return [list_value]
try:
# Use ast.literal_eval instead of eval for security - only evaluates literal expressions
import ast
list_value = ast.literal_eval(rendered_value)
if isinstance(list_value, list):
return list_value
else:
return [list_value]
except (ValueError, SyntaxError) as e:
# If ast.literal_eval fails, treat the rendered value as a single string item
return [rendered_value]


# Non-task-based blocks
Expand Down