Dev/28 exclude security config by default#30
Merged
Conversation
Moved from information events to log lines during export Added an option to include security settings or not. By default it will be excluded and it will trim any security settings unless opted in explicitly Exclude DevPack references from the package. Fixed version history
Bumps coverlet.collector from 8.0.0 to 10.0.1 Bumps Microsoft.NET.Test.Sdk from 18.3.0 to 18.5.1 Bumps MSTest.TestAdapter from 4.1.0 to 4.2.3 Bumps MSTest.TestFramework from 4.1.0 to 4.2.3 Bumps Skyline.DataMiner.Sdk from 2.4.6 to 2.5.2 Bumps Skyline.DataMiner.Utils.SecureCoding.Analyzers from 2.2.1 to 2.2.3 --- updated-dependencies: - dependency-name: Skyline.DataMiner.Sdk dependency-version: 2.5.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: Skyline.DataMiner.Sdk dependency-version: 2.5.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: Skyline.DataMiner.Sdk dependency-version: 2.5.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: Skyline.DataMiner.Sdk dependency-version: 2.5.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: Skyline.DataMiner.Sdk dependency-version: 2.5.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: Skyline.DataMiner.Sdk dependency-version: 2.5.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: Skyline.DataMiner.Utils.SecureCoding.Analyzers dependency-version: 2.2.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-dependencies - dependency-name: Skyline.DataMiner.Sdk dependency-version: 2.5.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: Skyline.DataMiner.Utils.SecureCoding.Analyzers dependency-version: 2.2.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-dependencies - dependency-name: Skyline.DataMiner.Sdk dependency-version: 2.5.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: Skyline.DataMiner.Utils.SecureCoding.Analyzers dependency-version: 2.2.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-dependencies - dependency-name: coverlet.collector dependency-version: 10.0.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-dependencies - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.5.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: MSTest.TestAdapter dependency-version: 4.2.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: MSTest.TestFramework dependency-version: 4.2.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: Skyline.DataMiner.Sdk dependency-version: 2.5.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-dependencies - dependency-name: Skyline.DataMiner.Utils.SecureCoding.Analyzers dependency-version: 2.2.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
…l-dependencies-20201b7333 Bump the all-dependencies group with 6 updates
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an export option to include or omit low-code app security settings by default, while also updating package/tooling references and WebApiLib deployment references.
Changes:
- Added an “Include Security Settings” checkbox and export option.
- Strips selected security arrays from
App.info.jsonunless security export is enabled. - Updated SDK/analyzer/test package versions and adjusted WebApiLib/package dependency handling.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
Low Code App EditorTests/Low Code App EditorTests.csproj |
Updates test package versions. |
Low Code App Editor/UI/ExportDialog.cs |
Adds the new security settings checkbox to the export dialog. |
Low Code App Editor/Low Code App Editor.xml |
Changes the WebApiLib runtime reference path. |
Low Code App Editor/Low Code App Editor.csproj |
Updates the secure coding analyzer package version. |
Low Code App Editor/Low Code App Editor.cs |
Updates revision history entries. |
Low Code App Editor/Controllers/ExportController.cs |
Implements security-setting trimming and related export packaging changes. |
Low Code App Editor Package/Low Code App Editor Package.csproj |
Updates the secure coding analyzer package version. |
Low Code App Editor Package/Low Code App Editor Package.cs |
Removes placeholder install comment while keeping symlink logic. |
Low Code App Editor Installer/Low Code App Editor Installer.csproj |
Updates the secure coding analyzer package version. |
global.json |
Updates the Skyline DataMiner SDK version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ithub.com/SkylineCommunications/Low-Code-App-Extensions into dev/28-exclude-security-config-by-default
…ithub.com/SkylineCommunications/Low-Code-App-Extensions into dev/28-exclude-security-config-by-default
…ithub.com/SkylineCommunications/Low-Code-App-Extensions into dev/28-exclude-security-config-by-default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new checkbox to include the security config (it's off by default).
Added the code to trim the security settings when the toggle button is not checked. Otherwise it will just copy the entire thing.