Skip to content

Commit

Permalink
add security handling process docs (#52)
Browse files Browse the repository at this point in the history
  • Loading branch information
Shikugawa authored Jan 15, 2021
1 parent b8cbd69 commit 05ff62e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ current_span->endSpan();
tracer->sendSegment(std::move(current_segment));
```

## Security

If you've found any security issues, please read [Security Reporting Process](https://github.com/SkyAPM/cpp2sky/blob/main/SECURITY.md) and take described steps.

## LICENSE

Apache 2.0 License. See [LICENSE](https://github.com/SkyAPM/cpp2sky/blob/main/LICENSE) for more detail.
3 changes: 3 additions & 0 deletions SECURITY.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Security Reporting Process

If you've found a security vulnerability on cpp2sky, please report the description and details to [email protected]. After that we will acknowledge about your report then send confiramation email.
4 changes: 2 additions & 2 deletions source/grpc_async_client_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ GrpcAsyncSegmentReporterClient::~GrpcAsyncSegmentReporterClient() {
// failed to send message and close stream, then recreate new stream and try
// to do it. This process will continue forever without sending explicit
// signal.
// TODO(shikugawa): Block to wait drained messages to be clear with createing condition
// variable wrapper.
// TODO(shikugawa): Block to wait drained messages to be clear with createing
// condition variable wrapper.
#ifndef TEST
if (stream_) {
std::unique_lock<std::mutex> lck(mux_);
Expand Down

0 comments on commit 05ff62e

Please sign in to comment.