Move dirty from Context to EagerDir #886
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For typed directories, ideally we'd need to keep keys and files in directories to avoid unsafe casts. There are a few cases of keys in the
Context
, some are more or less problematic.This move looks safe as
dirty
is only accessed in update, and only updated inwriteEntry
with no weird interleaving withsetDir
.Ideally, I'd do the same with
dirtyReaders
but there are too many interleavings, so there's a risk to exist asetDir
between a change and anothersetDir
, then missing some changes.