Skip to content

SKStore cleanups, last week of April #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

SKStore cleanups, last week of April #885

wants to merge 53 commits into from

Conversation

mbouaziz
Copy link
Contributor

Yet another round

@mbouaziz mbouaziz marked this pull request as draft April 29, 2025 17:23
@mbouaziz mbouaziz marked this pull request as ready for review April 30, 2025 08:44
mbouaziz added 27 commits April 30, 2025 11:53
@mbouaziz
Use Time#negate
12b1c32
@mbouaziz
EagerDir#reverseTime should probably negate the timestack too
39b262c
@mbouaziz
Make Dir#time protected
1e5c4b8
@mbouaziz
Remove Dir#time using invariant
00260ea 
Dir#time == Dir#timeStack.getLast()
@mbouaziz
Move calls to Context#timeStamp closer to their usage
180076d
@mbouaziz
Document Time
fe40908
@mbouaziz
Move weird SKDB-specific TimeStack methods to SKDB extension classes
d764b8a
@mbouaziz
Remove unnecessary timeStamp increase on update
63550ae 
It is already done before each dir creation.

It has an impact on 'LOCAL SEQUENCE NUMBER 2' SKDB unit test which
compares unique identifiers created using the runtime global genSym.
@mbouaziz
Simplify unsafeGetAllDataIterAfter
3167359
@mbouaziz
Make DataMapValue#items return the same type as itemsAfter
9bb7fc5
@mbouaziz
Simplify EagerDir#unsafeGetAllDataIter unmodified case
3ba73e8
@mbouaziz
Simplify EagerDir#unsafeGetAllDataIterAfter
2e6bd13
@mbouaziz
Make Context#mkdirMulti return a handle
bc9d307
@mbouaziz
Make FixedRow covariant in T
ddf8ed3
@mbouaziz
Make FixedData covariant in T
2990e63
@mbouaziz
Make IFixedDir covariant in T
b6bf51a
@mbouaziz
Merge IFixedDir#decode into get
c150292
@mbouaziz
Make FixedDir covariant in T
82e5983
@mbouaziz
Make type of Context#mkdirMulti more precise
7392e62
@mbouaziz
Remove unused SortedMap#removeMinBinding
b5cb0b8
@mbouaziz
Make SortedMap#removeMin return an option with the minimum
f667560
@mbouaziz
Use new, faster SortedMap#removeMin
283768b
@mbouaziz
Simplify EagerDir#update signature
66717a2
@mbouaziz
Avoid double get
fc8ab3e
@mbouaziz
Collect dirtyReaders in a SortedMap directly instead of doing it in t…
5241003 
…wo steps
@mbouaziz
Write invariant on Arrow in update
2c93bf9
@mbouaziz
Remove extra setDir
7a42c4a
mbouaziz added 26 commits April 30, 2025 11:53
@mbouaziz
Simplify strings
244959d
@mbouaziz
Remove EagerDir#writeArrayReturnDir
de6a7d5
@mbouaziz
Do reset in EagerDir#writeArraySourceManyReturnDir
6f58161
@mbouaziz
Remove EagerDir#writeArraySourceManyReturnDir
c8f75d5
@mbouaziz
Remove extra context clone
2e676d4
@mbouaziz
Context#purgeFrom requires a readonly context only
0c6be32
@mbouaziz
Simplify emptiness change condition
5a2ceb8
@mbouaziz
Move lazy function wrapper to a separate method
e0dce7f
@mbouaziz
Remove unused LazyDir#getArrayWithOptions
93423d0 
Last use removed in ae56d49
@mbouaziz
throwOnCycle is always true in LazyDir#unsafeGetArray
de5c031
@mbouaziz
Move getDir functions together
55eecd3
@mbouaziz
EagerDir#copy
5d1241e
@mbouaziz
Compute totalSize in EagerDir constructor
4d3746c
@mbouaziz
Remove EagerDir#isInput
ffb877f 
Used only once
EagerDir#input is public already
@mbouaziz
Use EagerDir#unsafeGetAllDataIter in tests
6f125a9
@mbouaziz
Remove dead EagerDir#optCopy
93e5fc8
@mbouaziz
Remove dead class ToWrite
3863056
@mbouaziz
Make some EagerDir fields private
66d40e1
@mbouaziz
Remove EagerDir#onFiles
e95e4f4
@mbouaziz
Remove EagerDir#getAllDataIter and unnecessary context clone
5c86577
@mbouaziz
Make some EagerDir methods private
20780fe
@mbouaziz
purgeSlices requires a readonly Context only
229c22b
@mbouaziz
Make FixedSingle default constructor private
0aae122
@mbouaziz
Save a collect
1404e3f
@mbouaziz
TimeStack#compare is the default comparison already
07176bd
@mbouaziz
Pass parent dirty to EagerDirty#update
e628a3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skiplabsdaniel skiplabsdaniel skiplabsdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbouaziz @skiplabsdaniel