Skipsocial #431
Draft
Skipsocial #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a stopgap and is no longer used.
This was a stopgap, and is no longer used.
Some cleanups and improved inline documentation for Skip runtime, focusing on `skipruntime_api.ts` to make sure everything is understandable and well-documented.
This isolates the compute graph definition from writing into input directories.
A few cosmetic changes to separate the compute graph definition vs triggering of actual compute (by writing to input directories).
AFAIU it is not being used anymore.
Add TWritter append function Add ErrorObject to Error convertion
This wasn't caught by CI because CI was in an inconsistent state (cf. SkipLabs#374).
This wasn't caught by CI because CI was in an inconsistent state (cf. SkipLabs#374).
@skip-wasm++
Looks like different JS runtimes use different values for this opaque type. https://stackoverflow.com/questions/51376589/typescript-what-type-is-setinterval
...of both regular Mappers and the specialized one-to-one and many-to-one variants
This came up in writing some small examples, and I figured it would be common enough that a prefab util would be useful.
…per utility (SkipLabs#441) I added the CountMapper utility as it came up while writing examples, and I figured it's a common enough thing that a prefab util version may be useful.
Writing docs about external services/resources/suppliers, I found the namings to be quite confusing and at times conflicting or redundant. The previous situatiuon was as follows: `ExternalSupplier` is an umbrella interface for all kinds of external data sources, whether skip or not. It had two main implementations: `ExternalService` for generic non-skip externals, and `ExternalSkipService` for skip externals. `ExternalService`s were composed of multiple `ExternalResource`s and `ExternalSkipService`s also had an internal notion of "resource"; skip services had a field "externalServices" which held a collection of "ExternalSupplier"s, etc. etc. This diff attempts to unify/streamline the naming scheme. The umbrella interface is now `ExternalService`, and it is implemented by `SkipExternalService` and `GenericSkipService`. Both forms have a notion of resource still, but they are analogous and I don't think will cause too much trouble. There may still be some places where parameter/variable names are conflicting as that's tricky to grep for, but I tried to find/fix the ones I could. I'm continuing to work on further in-code and markdown docs around this stuff, but thought I'd put this up to get feedback and minimize rebase pain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just putting this draft up here so that people can follow along on my little project. Clearly not ready for review (at all!)