-
Notifications
You must be signed in to change notification settings - Fork 24
Insight Backend #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gregsexton
wants to merge
3,230
commits into
SkipLabs:main
Choose a base branch
from
gregsexton:insight-be
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Insight Backend #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs#341) Prior to this commit, running `skargo build --out-dir /some/path` would not copy final build artifacts to `/some/path` if no unit needed to be rebuilt. Blocked by SkipLabs#340
Following SkipLabs#340, wasm libraries are now exported as `lib{package-name}.wasm` instead of `{package-name}.wasm`.
Following SkipLabs#340, wasm libraries are now exported as `lib{package-name}.wasm` instead of `{package-name}.wasm`.
Skargo now supports generating wasm libraries rather than the previous hack of generating wasm "binaries".
Remove skdb Manage subscribe Update tests
The `package.json`/`tsconfig.json` files are now in the root of the typescript package directory, rather than under `src/`.
Creating a npm package to share the base config, as recommended by the [eslint docs](https://eslint.org/docs/latest/extend/shareable-configs).
This is done in a separate commit so that git tracks that it was moved during the previous commit.
This is done in a separate commit so that git tracks that it was moved during the previous commit.
Context: The `sklib` file format is a ranlib archive that contains possible object files from C extensions, as well as skip-specific metadata. It can thus be passed straight to the linker, or be used by `skc`. Part of the required metadata is information about the defined (skip) symbols in the sklib. In practice, we pack the source code of all files from the package into the sklib. So far, the skip source files were embedded as members of the ranlib archive, which works fine on Linux as the linker seems to ignore files that are not ELF objects, but causes issues on macOS, where the linker complains about non Mach-O files. In order to work around this, the idea is to pack the source files of the package along with the metadata inside the `lib.skmeta` member of the archive. This would still be an issue, but the next step is to embed the `lib.skmeta` into a dummy object file, leaving a clean ranlib archive that should please any linker.
Context: The `sklib` file format is a ranlib archive that contains possible object files from C extensions, as well as skip-specific metadata. It can thus be passed straight to the linker, or be used by `skc`. Part of the required metadata is information about the defined (skip) symbols in the sklib. In practice, we pack the source code of all files from the package into the sklib. So far, the skip source files were embedded as members of the ranlib archive, which works fine on Linux as the linker seems to ignore files that are not ELF objects, but causes issues on macOS, where the linker complains about non Mach-O files. In order to work around this, the idea is to pack the source files of the package along with the metadata inside the `lib.skmeta` member of the archive. This would still be an issue, but the next step is to embed the `lib.skmeta` into a dummy object file, leaving a clean ranlib archive that should please any linker.
And appease the Dockerfile linter.
And appease the Dockerfile linter.
This renders a debug trace given a static JSON file that is generated by SKStore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supplies the data as used by the UI (see PR #339).
There is a networking PR to connect them but the rebase is extremely painful, so I've carved this out separately.