Stratum v2 Template Provider common functionality #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2024
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
3cf779b to
b549fd6
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
2 times, most recently
from
6894e23 to
fc6ac1e
Compare
|
Updated to the latest interface changes proposed in bitcoin#30409 and #53. |
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
b549fd6 to
22d033c
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
2 times, most recently
from
491755c to
16d2381
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
3 times, most recently
from
4f957ee to
b69544c
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
2 times, most recently
from
ca73422 to
4fa25e0
Compare
|
Rebased for CMake |
|
One test still seems brittle: |
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
b69544c to
1ca68d2
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
1f720ff to
1912743
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
1ca68d2 to
b578e0a
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
2 times, most recently
from
598f08a to
436dc4d
Compare
|
Moved |
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
436dc4d to
46fa8f1
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
b578e0a to
489c9fb
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
2 times, most recently
from
7db898e to
765af74
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
deb8e90 to
903fe1a
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
0d588c2 to
33d42ff
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
903fe1a to
7fb1a19
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
33d42ff to
96bc151
Compare
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
7fb1a19 to
2503578
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
96bc151 to
6b5dfc5
Compare
|
Possible thread issue, found by CI in #68: https://cirrus-ci.com/task/5072000852426752?logs=ci#L3303 |
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
2503578 to
360aedd
Compare
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
6b5dfc5 to
fe053b0
Compare
|
Rebased after bitcoin#31384. |
Sjors
force-pushed
the
2024/06/sv2_connection
branch
from
360aedd to
49ea07a
Compare
This was preventing the (hidden) waitfornewblock, waitforblock and waitforblockheight methods from being used in the GUI. The check was added in d6a5dc4 when these RPC methods were first introduced. They could have been dropped when dca9231 refactored these methods to use waitTipChanged(), which already checks for shutdown. Making this change now simplifies the next commit.
The waitTipChanged() now returns nullopt if the node is shutting down. Previously it would return the last known tip during shutdown, but this creates an ambiguous circumstance in the scenario where the node is started and quickly shutdown, before notifications().TipBlock() is set. The getblocktemplate, waitfornewblock and waitforblockheight RPC are updated to handle this. Existing behavior is preserved. Co-authored-by: Ryan Ofsky <[email protected]>
Additionally it returns null if the node started to shutdown before TipBlock() was set.
Move the comparison to hashWatchedChain inside the while loop. Although this early return prevents the GetTransactionsUpdated() call in cases where the tip updates, it's only done to improve readability. The check itself is very cheap (although a more useful check might not be). Also add code comments.
On testnet we need to create a min diff template after 20 min.
The template provider will listen for a Job Declarator client. It can establish a connection and detect various protocol errors. Co-Authored-By: Christopher Coverdale <[email protected]> Co-Authored-By: Fi3
Co-authored-by: Christopher Coverdale <[email protected]>
Determine future_template only once
Co-authored-by: Vasil Dimov <[email protected]>
Sjors
force-pushed
the
2024/07/sv2-tp-common
branch
from
fe053b0 to
5c3f9cb
Compare
|
Rebased in hopes of making #80 magically go away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from bitcoin#30475.
Based on:
And the following interface changes:
This contains all Template Provider functionality that can be used by both #68 and the IPC based sidecar alternative #48.