Skip to content

[Fix] filter dropdown panels stacking by removing default Popover forceMount - Staging PR#741

Merged
sc-ishankalakshan merged 2 commits into
stagingfrom
dev
Jun 26, 2026
Merged

[Fix] filter dropdown panels stacking by removing default Popover forceMount - Staging PR#741
sc-ishankalakshan merged 2 commits into
stagingfrom
dev

Conversation

@sc-ArshadHannan

Copy link
Copy Markdown
Collaborator
  • Removes the default forceMount={true} from PopoverContent in src/components/ui/popover.tsx.
  • Closed popover content was staying mounted in the DOM and rendering with position: static, which caused multi-select filter dropdown panels to stack in the page flow instead of floating over content.
  • This was most visible on the Filter docs page (/primitives/filter), where multiple closed dropdowns added hundreds of pixels of ghost content and made the page appear to scroll with stacked filter menus.

A previous ARIA-related change set forceMount={true} by default on both PopoverPrimitive.Portal and PopoverPrimitive.Content. When closed, Radix did not apply floating positioning, so those panels remained visible in document flow.

SC-vishathamarasinghe and others added 2 commits June 26, 2026 09:11
[Fix] filter dropdown panels stacking by removing default Popover forceMount
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
blok-shadcn Ready Ready Preview, Comment Jun 26, 2026 5:52am

Request Review

@sc-ishankalakshan sc-ishankalakshan merged commit 0d4c099 into staging Jun 26, 2026
9 of 11 checks passed
@github-actions

Copy link
Copy Markdown

❌ Playwright Test Results

@sc-ArshadHannan

Status: Failed | Workflow: Playwright Tests

Metric Count
Total Tests 69
Passed 55
Failed 14
⏭️ Skipped 0

Component Installation

  • Registry URL: https://blok-staging.vercel.app (staging)
  • Components were installed and tested using the staging registry

Details

Test Report

  • Playwright Report: Download Report
    • Download the playwright-report artifact from the workflow run
    • Extract and open index.html in a browser to view the full HTML report
    • The report includes detailed test results, screenshots, and traces

Some tests failed. Please review the test results and download the report for details.


This is an automated notification from GitHub Actions. Email notifications are sent to mentioned users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants