refactor(loader): renames _load_from_source to _load_from_local_source removes unreachable code and adds tests for _load_from_local_source #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, removes unreachable code and adds tests for _load_from_local_source
…into release/v3 * 'release/v3' of https://github.com/scaliseraoul/pandas-ai: ci: fix lint refactor: remove workspace
dosubot
bot
added
the
size:M
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 01c125b in 56 seconds
More details
- Looked at
102lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pandasai/data_loader/loader.py:175
- Draft comment:
Ensure thatInvalidDataSourceTypeis defined and imported correctly to avoid runtime errors when raising this exception. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_NsgdJOZBNiboVtVh
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
scaliseraoul
added a commit
to scaliseraoul/pandas-ai
that referenced
this pull request
Jan 14, 2025
…into release/v3 * 'release/v3' of https://github.com/scaliseraoul/pandas-ai: refactor(loader): renames _load_from_source to _load_from_local_source removes unreachable code and adds tests for _load_from_local_source (Sinaptik-AI#1514)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_load_from_sourcewas only called in one place after checking forself.schema["source"]["type"] in LOCAL_SOURCE_TYPES:meaning the code after the same check was unreachable and unsafe. Renamed for consistency and added testsImportant
Refactor
_load_from_sourceto_load_from_local_source, remove unreachable code, and add tests for_load_from_local_source._load_from_sourceto_load_from_local_sourceinloader.py._load_from_local_source.test_load_from_local_source_validandtest_load_from_local_source_invalid_source_typeintest_loader.pyto verify behavior of_load_from_local_source.test_load_from_cacheto use_load_from_local_source.This description was created by
for 01c125b. It will automatically update as commits are pushed.