Do not set secp256k1 error callback #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error callback in secp256k1 should not ever return. The default one prints a message to stderr and does abort() This is a really exceptional situation with no safe recovery, so there's no sense in handling it in python. Better just use the default handler.
|
As per rust-bitcoin/rust-secp256k1#228, the error callback should never return. It seems that illegal callback returning could be OK, and it may be better for debugging incorrect function usage, rather than having an abort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error callback in secp256k1 should not ever return.
The default one prints a message to stderr and does abort()
This is a really exceptional situation with no safe recovery, so
there's no sense in handling it in python. Better just use the default
handler.