Fix popups by always sending cookies #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mustafa Can Elmacı <[email protected]>
Contributor
Author
jdarwood007
approved these changes
May 24, 2025
Member
jdarwood007
left a comment
jdarwood007
left a comment
There was a problem hiding this comment.
The intent was that SMF would be loaded and thus call variables that SMF provides during its theme startup. But that does not happen because we are not fully starting up SMF even to do the menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sent me down a hours long rabbit hole where I changed every cookie setting, adding/removing CORS domains and headers, disabling Frame Security Options, and even reading RFC 2606 and changing my development domain from forum.smf.local to forum.smf.test.
There is absolutely no use case where doing ajax to SMF and not sending cookies, since SMF will always redirect us to the login page anyway.