Skip to content

Conversation

@0ubbe
Copy link
Contributor

@0ubbe 0ubbe commented Dec 4, 2025

Changes πŸ—οΈ

Screenshot 2025-12-04 at 21 05 55

Allow to close toasts 🍞

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Run Storybook locally
    • Toast have a close button top-right

@0ubbe 0ubbe requested a review from a team as a code owner December 4, 2025 14:07
@github-project-automation github-project-automation bot moved this to πŸ†• Needs initial review in AutoGPT development kanban Dec 4, 2025
@netlify
Copy link

netlify bot commented Dec 4, 2025

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit 6022784
πŸ” Latest deploy log https://app.netlify.com/projects/auto-gpt-docs-dev/deploys/6936a3c9693cde000888bdc6

@coderabbitai
Copy link

coderabbitai bot commented Dec 4, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/closing-toasts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the platform/frontend AutoGPT Platform - Front end label Dec 4, 2025
@netlify
Copy link

netlify bot commented Dec 4, 2025

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit 6022784
πŸ” Latest deploy log https://app.netlify.com/projects/auto-gpt-docs/deploys/6936a3c902295b000873d002

@github-actions github-actions bot added the size/m label Dec 4, 2025
@qodo-code-review
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 πŸ”΅βšͺβšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Visual Regression

Forcing absolute positioning of the close button with negative right/top offsets and !important may misalign on different toast sizes or themes. Verify across variants (success/error/info) and responsive breakpoints, and ensure RTL layouts are handled if applicable.

/* Position close button on the right */
html body [data-sonner-toast] [data-close-button] {
  left: unset !important;
  right: -18px !important;
  top: -3px !important;
}
Unused Import

The icon imports appear unused in this component after the change. Consider removing them or confirm they are required by Sonner via context; otherwise tree-shaking might handle it, but explicit cleanup is clearer.

import { CheckCircle, Info, Warning, XCircle } from "@phosphor-icons/react";
import { Toaster as SonnerToaster } from "sonner";

@deepsource-io
Copy link

deepsource-io bot commented Dec 4, 2025

Here's the code health analysis summary for commits 8be3c88..6022784. View details on DeepSourceΒ β†—.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScriptβœ…Β SuccessView CheckΒ β†—
DeepSource Python LogoPythonβœ…Β SuccessView CheckΒ β†—

πŸ’‘ If you’re a repository administrator, you can configure the quality gates from the settings.

Abhi1992002
Abhi1992002 previously approved these changes Dec 4, 2025
@github-project-automation github-project-automation bot moved this from πŸ†• Needs initial review to πŸ‘πŸΌ Mergeable in AutoGPT development kanban Dec 4, 2025
majdyz
majdyz previously approved these changes Dec 4, 2025
@0ubbe 0ubbe merged commit a46976d into dev Dec 8, 2025
33 checks passed
@github-project-automation github-project-automation bot moved this to Done in Frontend Dec 8, 2025
@github-project-automation github-project-automation bot moved this from πŸ‘πŸΌ Mergeable to βœ… Done in AutoGPT development kanban Dec 8, 2025
@0ubbe 0ubbe deleted the fix/closing-toasts branch December 8, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: βœ… Done
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants