Skip to content

fix(core): throw on unimplemented migration sources instead of silently no-oping#748

Open
Alexi5000 wants to merge 1 commit into
Signet-AI:mainfrom
Alexi5000:pr/chatgpt-migration-parser
Open

fix(core): throw on unimplemented migration sources instead of silently no-oping#748
Alexi5000 wants to merge 1 commit into
Signet-AI:mainfrom
Alexi5000:pr/chatgpt-migration-parser

Conversation

@Alexi5000
Copy link
Copy Markdown

Summary

  • Replace silent console.log stubs in migrateChatGPT(), migrateClaude(), and migrateGemini() with explicit throw new Error() calls
  • Prefix unused inputPath parameters with underscore to satisfy linters
  • Callers of migrate() now get a clear error instead of a successful no-op when using an unimplemented source

Motivation

The current stubs in platform/core/src/migrate.ts log a message and return successfully, which means callers have no way to distinguish between a successful migration and one that did nothing. This can mask issues in tooling that depends on migrate().

Test Plan

  • Calling migrate({ source: 'chatgpt', inputPath: '...' }) now throws with a descriptive error
  • Same for claude and gemini sources
  • The default case in the switch still throws for unknown sources

…ly no-oping

The ChatGPT, Claude.ai, and Gemini migration stubs only called
console.log and returned successfully, giving callers no indication
that migration was not performed. Replace with explicit errors so
consumers know the feature is pending. Prefix unused params with
underscore to satisfy linters.
@PR-Reviewer-Ant
Copy link
Copy Markdown
Collaborator

Hi @Alexi5000 - I'm taking a look at the fixes in fix(core): throw on unimplemented migration sources instead of silently no-oping (commit 8e98444c) and will follow up shortly.

This comment is updated in place by pr-reviewer.

Copy link
Copy Markdown
Collaborator

@PR-Reviewer-Ant PR-Reviewer-Ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata
  • Reviewer: pr-reviewer
  • Model: gpt-5.5
  • Commit: 8e98444c

The implementation matches the PR description: the three currently unimplemented migration sources now fail explicitly instead of logging and returning success. I did not find a correctness, security, or data-integrity issue in this diff.

Confidence: High [sufficient_diff_evidence, targeted_context_included] - The changed file is small and the diff directly covers the described behavior in platform/core/src/migrate.ts. Each implemented switch branch still dispatches as before, and each unimplemented source now throws a descriptive Error instead of silently returning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants