-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(logs-context): implement priority-based resource attribute selection #9303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is an example log that I took and service.name is filter is appearing twice. although the result is correct it shouldn't happen
{
"body": "hello error",
"date": "2025-10-13T15:02:08.20352512+05:30",
"id": "0iEqJIw1jdPs0XtC40W6tDIgvbk",
"timestamp": "2025-10-13T15:02:08.20352512+05:30",
"attributes": {
"code.lineno": 117,
"timestamp": 1760071793000000000,
"code.filepath": "/Users/nityanandagohain/projects/examples/python-logs/gen_old_timestamp.py",
"code.function": "<module>",
"error.code": "200"
},
"resources": {
"mynum:xyz": "126",
"process.command_args": "testtgg",
"service.instance.id": "inst-123",
"service.name": "test",
"source_type": "testing",
"telemetry.sdk.language": "python",
"telemetry.sdk.name": "opentelemetry",
"telemetry.sdk.version": "1.27.0",
"xyzxxxxx": "hello"
},
"scope": {},
"severity_text": "ERROR",
"severity_number": 17,
"scope_name": "opentelemetry.sdk._logs._internal",
"scope_version": "",
"span_id": "",
"trace_flags": 0,
"trace_id": ""
}

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not update the old regex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
📄 Summary
✅ Changes
🏷️ Required: Add Relevant Labels
ex:
frontend
backend
devops
bug
enhancement
ui
test
👥 Reviewers
🧪 How to Test
🔍 Related Issues
Closes #9147
📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)
Before:

After:

📋 Checklist
👀 Notes for Reviewers