Skip to content

Conversation

ahmadshaheer
Copy link
Collaborator

@ahmadshaheer ahmadshaheer commented Oct 10, 2025

📄 Summary


✅ Changes

  • Feature: Brief description
  • Bug fix: Brief description

🏷️ Required: Add Relevant Labels

⚠️ Manually add appropriate labels in the PR sidebar
Please select one or more labels (as applicable):

ex:

  • frontend
  • backend
  • devops
  • bug
  • enhancement
  • ui
  • test

👥 Reviewers

Tag the relevant teams for review:

  • frontend / backend / devops

🧪 How to Test

  1. ...
  2. ...
  3. ...

🔍 Related Issues

Closes #9147


📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)

Before:
Screenshot 2025-10-10 094311

After:
Screenshot 2025-10-10 094334


📋 Checklist

  • Dev Review
  • Test cases added (Unit/ Integration / E2E)
  • Manually tested the changes

👀 Notes for Reviewers

@ahmadshaheer ahmadshaheer requested review from a team and YounixM as code owners October 10, 2025 04:33
@ahmadshaheer ahmadshaheer marked this pull request as draft October 10, 2025 04:34
@github-actions github-actions bot added the enhancement New feature or request label Oct 10, 2025
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an example log that I took and service.name is filter is appearing twice. although the result is correct it shouldn't happen

{
  "body": "hello error",
  "date": "2025-10-13T15:02:08.20352512+05:30",
  "id": "0iEqJIw1jdPs0XtC40W6tDIgvbk",
  "timestamp": "2025-10-13T15:02:08.20352512+05:30",
  "attributes": {
    "code.lineno": 117,
    "timestamp": 1760071793000000000,
    "code.filepath": "/Users/nityanandagohain/projects/examples/python-logs/gen_old_timestamp.py",
    "code.function": "<module>",
    "error.code": "200"
  },
  "resources": {
    "mynum:xyz": "126",
    "process.command_args": "testtgg",
    "service.instance.id": "inst-123",
    "service.name": "test",
    "source_type": "testing",
    "telemetry.sdk.language": "python",
    "telemetry.sdk.name": "opentelemetry",
    "telemetry.sdk.version": "1.27.0",
    "xyzxxxxx": "hello"
  },
  "scope": {},
  "severity_text": "ERROR",
  "severity_number": 17,
  "scope_name": "opentelemetry.sdk._logs._internal",
  "scope_version": "",
  "span_id": "",
  "trace_flags": 0,
  "trace_id": ""
}
image

Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not update the old regex

@ahmadshaheer ahmadshaheer marked this pull request as ready for review October 14, 2025 05:37
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LOG: Logs context filter selection logic

2 participants