Skip to content

Conversation

Ms-Kulkarni
Copy link

@Ms-Kulkarni Ms-Kulkarni commented Oct 4, 2025

📄 Summary

This PR fixes the issue where logs are not highlighted when accessed via a shared copy link. The fix adds auto-scroll functionality to the useEffect hook, ensuring that when a user opens a shared log link, the specific log entry is automatically scrolled into view and highlighted in the center of the viewport.


✅ Changes

  • Bug fix: Added activeLogIndex to useEffect dependencies to trigger scroll on log selection
  • Bug fix: Implemented scrollToIndex functionality with center alignment for better UX
  • Bug fix: Logs now properly highlight when accessed via shared URLs

🏷️ Required: Add Relevant Labels

⚠️ Manually add appropriate labels in the PR sidebar
Please select one or more labels (as applicable):

  • frontend
  • bug
  • ui
  • logs

👥 Reviewers

Tag the relevant teams for review:

  • frontend

🔍 Related Issues

Fixes #8952


📋 Checklist

  • Dev Review
  • Test cases added (Unit/ Integration / E2E)
  • Manually tested the changes

Important

Fixes log highlighting issue by adding activeLogIndex to useEffect dependencies and using scrollToIndex in index.tsx.

  • Bug Fix:
    • In index.tsx, added activeLogIndex to useEffect dependencies to trigger scroll on log selection.
    • Implemented scrollToIndex with center alignment to ensure logs are highlighted when accessed via shared URLs.

This description was created by Ellipsis for db46f03. You can customize this summary. It will automatically update as commits are pushed.

@Ms-Kulkarni Ms-Kulkarni requested review from a team and YounixM as code owners October 4, 2025 19:11
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


M s kulkarni seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to db46f03 in 1 minute and 5 seconds. Click for details.
  • Reviewed 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. frontend/src/container/LogsExplorerList/index.tsx:87
  • Draft comment:
    Good update in the useEffect: auto-scroll is now triggered when logs are loaded and an active log exists. This ensures that a shared log link properly highlights the log entry.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. frontend/src/container/LogsExplorerList/index.tsx:98
  • Draft comment:
    Including activeLogIndex in the dependency array correctly ensures the scroll is re-triggered when the active log changes. Verify that frequent changes in activeLogIndex do not cause unwanted side effects.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_85RWscZvP2XoPHpN

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlight log when shared via copy link

2 participants