Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add write cache for span attribute keys and traces_v3_resource #476

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Add write cache for span attribute keys and traces_v3_resource #476

merged 2 commits into from
Dec 6, 2024

Conversation

srikanthccv
Copy link
Member

Fixes #473 and traces part of #472

nityanandagohain
nityanandagohain reviewed Dec 6, 2024
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a nit comment

utils/utils.go Show resolved Hide resolved
@srikanthccv srikanthccv merged commit f848d2b into main Dec 6, 2024
3 checks passed
@srikanthccv srikanthccv deleted the traces-write-cache branch December 6, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nityanandagohain nityanandagohain nityanandagohain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(traces): implement write cache for attribute keys and resource attribute in exporter
2 participants
@srikanthccv @nityanandagohain