Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: templatize migrations #184

Merged
merged 38 commits into from
Oct 19, 2023
Merged

feat: templatize migrations #184

merged 38 commits into from
Oct 19, 2023

Conversation

dhawal1248
Copy link
Contributor

Fixes #180

@dhawal1248 dhawal1248 marked this pull request as ready for review October 10, 2023 12:06
@srikanthccv
Copy link
Member

There are still some instances of hard-coded cluster name ON CLUSTER cluster. Please make sure all of them are templatized.

nityanandagohain
nityanandagohain requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make commands are not working as the dockerfiles are not updated.

@dhawal1248
Copy link
Contributor Author

dhawal1248 commented Oct 11, 2023 •
edited
Loading

There are still some instances of hard-coded cluster name ON CLUSTER cluster. Please make sure all of them are templatized.

Yes @srikanthccv , i found a few missed occurences of on CLUSTER cluster while testing, have changed all of them.There were also a few occurences of Distributed("cluster", ...) i had missed..have changed them too

srikanthccv
srikanthccv reviewed Oct 12, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
cmd/signozcollectormigrator/Dockerfile Outdated Show resolved Hide resolved
cmd/signozcollectormigrator/migrate.go Outdated Show resolved Hide resolved
cmd/signozcollectormigrator/migrate.go Outdated Show resolved Hide resolved
cmd/signozcollectormigrator/migrate.go Outdated Show resolved Hide resolved
cmd/signozcollectormigrator/migrate.go Outdated Show resolved Hide resolved
migrationManager/migrators/baseMigrator/migrator.go Outdated Show resolved Hide resolved
srikanthccv
srikanthccv approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comments

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
cmd/signozschemamigrator/migrate.go Outdated Show resolved Hide resolved
example/docker-compose.yml Outdated Show resolved Hide resolved
example/docker-compose.yml Outdated Show resolved Hide resolved
example/example-config.yaml Outdated Show resolved Hide resolved
nityanandagohain
nityanandagohain requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change, rest looks good to me

migrationmanager/migrators/logs/migrations/000005_attribute_rename.down.sql Show resolved Hide resolved
@prashant-shahi prashant-shahi merged commit b751521 into main Oct 19, 2023
2 checks passed
@prashant-shahi prashant-shahi deleted the feat.templatizeMigrations branch October 19, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nityanandagohain nityanandagohain nityanandagohain approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@prashant-shahi prashant-shahi prashant-shahi approved these changes

@ankitnayan ankitnayan Awaiting requested review from ankitnayan

@makeavish makeavish Awaiting requested review from makeavish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: Is there any way to choose cluster name?
4 participants
@dhawal1248 @srikanthccv @prashant-shahi @nityanandagohain