Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts PSSE branch-type inference so that PSSE transformers are parsed as TapTransformer by default (rather than sometimes Transformer2W), aiming to avoid mixed transformer-type parsing (e.g., in parallel workflows).
Changes:
- Updated PSSE branch-type inference to return
TapTransformerfor (non-phase-shifting) transformers regardless of tap controllability. - Updated PSSE parsing tests to look up the affected transformers as
TapTransformerinstead ofTransformer2W. - Updated a related warning message in
_determine_control_modes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/parsers/power_models_data.jl |
Changes PSSE transformer type selection to prefer TapTransformer; adjusts related warning message. |
test/test_parse_psse.jl |
Updates PSSE parsing tests to expect TapTransformer for specific transformers previously retrieved as Transformer2W. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
The downstream cross package test failures in PSI are due to network formulations that require all device types to be formulated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse all transformers from PSSE as tap transformer by default, to avoid parsing mixed transformer types in parallel.