Skip to content

parse tap transformers from psse#1676

Open
m-bossart wants to merge 3 commits intomainfrom
mb/parse-tap-transformers
Open

parse tap transformers from psse#1676
m-bossart wants to merge 3 commits intomainfrom
mb/parse-tap-transformers

Conversation

@m-bossart
Copy link
Copy Markdown
Contributor

Parse all transformers from PSSE as tap transformer by default, to avoid parsing mixed transformer types in parallel.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts PSSE branch-type inference so that PSSE transformers are parsed as TapTransformer by default (rather than sometimes Transformer2W), aiming to avoid mixed transformer-type parsing (e.g., in parallel workflows).

Changes:

  • Updated PSSE branch-type inference to return TapTransformer for (non-phase-shifting) transformers regardless of tap controllability.
  • Updated PSSE parsing tests to look up the affected transformers as TapTransformer instead of Transformer2W.
  • Updated a related warning message in _determine_control_modes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/parsers/power_models_data.jl Changes PSSE transformer type selection to prefer TapTransformer; adjusts related warning message.
test/test_parse_psse.jl Updates PSSE parsing tests to expect TapTransformer for specific transformers previously retrieved as Transformer2W.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/parsers/power_models_data.jl Outdated
Comment thread src/parsers/power_models_data.jl Outdated
Comment thread src/parsers/power_models_data.jl
Comment thread src/parsers/power_models_data.jl
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread src/parsers/power_models_data.jl
Comment thread src/parsers/power_models_data.jl Outdated
Comment thread test/test_parse_psse.jl Outdated
Comment thread src/parsers/power_models_data.jl
Comment thread src/parsers/power_models_data.jl
@m-bossart
Copy link
Copy Markdown
Contributor Author

The downstream cross package test failures in PSI are due to network formulations that require all device types to be formulated.

@m-bossart m-bossart requested review from jd-lara May 6, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants