Unitful getters and setters

Project.toml

@@ -12,8 +12,13 @@ JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
 PrettyTables = "08abe8d2-0d0c-5749-adfa-8a2ac140af0d"
+StructTypes = "856f2bd8-1eba-4b0a-8007-ebc267875bd4"
 TimeSeries = "9e3dc215-6440-5c97-bce1-76c03772f85e"
 Unicode = "4ec0a83e-493e-50e2-b9ac-8f72acf5a8f5"
+Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"
+
+[sources]
+InfrastructureSystems = {url = "https://github.com/NREL-Sienna/InfrastructureSystems.jl.git", rev = "lk/units-domain-agnostic-is4"}
 
 [compat]
 DataStructures = "^0.19"
@@ -24,9 +29,8 @@ JSON = "^1.5"
 LinearAlgebra = "1"
 Logging = "1"
 PrettyTables = "3.1"
+StructTypes = "^1.9"
 TimeSeries = "0.25"
 Unicode = "1"
+Unitful = "^1.12"
 julia = "^1.10"
-
-[sources]
-InfrastructureSystems = {url = "https://github.com/NREL-Sienna/InfrastructureSystems.jl", rev = "IS4"}

src/PowerSystems.jl

@@ -517,7 +517,6 @@ export set_name!
 export get_component_uuids
 export get_description
 export set_description!
-export get_base_power
 export get_frequency
 export get_frequency_droop
 export set_units_base_system!
@@ -591,6 +590,20 @@ export StructDefinition
 export generate_struct_file
 export generate_struct_files
 export UnitSystem # internal.jl
+# Unit types for explicit units in getters/setters
+export MW, Mvar, MVA, kV, OHMS, SIEMENS
+export DU, SU, NU, DeviceBaseUnit, SystemBaseUnit, NaturalUnit
+export AbstractRelativeUnit, RelativeQuantity
+export UnitCategory,
+    PowerCategory, ImpedanceCategory, AdmittanceCategory,
+    VoltageCategory, CurrentCategory
+export POWER, IMPEDANCE, ADMITTANCE, VOLTAGE, CURRENT
+export natural_unit, base_value, system_base_value, convert_units, DEFAULT_UNITS
+export ustrip
+# Hand-written unit-bearing companions for `exclude_getter` descriptor entries
+# (their bare-number counterparts get exported via generated/includes.jl).
+export get_base_power_unitful
+export get_base_power_12_unitful, get_base_power_23_unitful, get_base_power_13_unitful
 
 # ComponentSelector
 export ComponentSelector
@@ -623,6 +636,22 @@ import DataStructures: OrderedDict, SortedDict
 import JSON
 import Base.to_index
 import PrettyTables
+import Unitful
+using Unitful: @u_str, @unit, Quantity, Units, uconvert
+import StructTypes
+
+# Relative-unit primitives live in IS; PSY re-exports them for downstream
+# packages so that `PSY.DU`, `PSY.RelativeQuantity`, etc. keep working.
+import InfrastructureSystems:
+    AbstractRelativeUnit,
+    DeviceBaseUnit,
+    SystemBaseUnit,
+    NaturalUnit,
+    RelativeQuantity,
+    DU,
+    SU,
+    NU,
+    ustrip
 
 # Import InfrastructureSystems both as full module name (needed for internal macros like @forward)
 # and with alias for convenient usage throughout the codebase
@@ -819,6 +848,11 @@ include("utils/logging.jl")
 include("utils/IO/base_checks.jl")
 include("utils/generate_struct_files.jl")
 
+# Units machinery (formerly PowerSystemsUnits.jl)
+include("units/types.jl")
+include("units/conversions.jl")
+include("units/serialization.jl")
+
 include("definitions.jl")
 include("models/static_models.jl")
 include("models/dynamic_models.jl")
@@ -922,4 +956,8 @@ precompile(
     (TupleTimeSeries{StartUpStages}, ThermalStandard, Dates.DateTime),
 )
 
+function __init__()
+    Unitful.register(PowerSystems)
+end
+
 end # module

src/base.jl

@@ -449,9 +449,24 @@ Return a user-modifiable dictionary to store extra information.
 get_ext(sys::System) = IS.get_ext(sys.internal)
 
 """
-Return the system's base power.
+Unitless system base power (MVA) — internal anchor for unit conversion.
 """
-get_base_power(sys::System) = sys.units_settings.base_value
+_get_base_power(sys::System) = sys.units_settings.base_value
+
+"""
+Return the system's base power as a bare number in the requested units (e.g.
+`NU`, `MW`, `SU`). For the unit-bearing value see [`get_base_power_unitful`](@ref).
+"""
+get_base_power(sys::System, u) = IS._strip_units(get_base_power_unitful(sys, u))
+
+"""
+Return the system's base power as a unit-bearing quantity. See
+[`get_base_power`](@ref) for a bare number.
+"""
+get_base_power_unitful(sys::System, ::NaturalUnit) = _get_base_power(sys) * MVA
+get_base_power_unitful(sys::System, u::Unitful.Units) =
+    Unitful.uconvert(u, _get_base_power(sys) * MVA)
+get_base_power_unitful(sys::System, ::SystemBaseUnit) = 1.0 * SU
 
 """
 Return the system's frequency.
@@ -2341,7 +2356,7 @@ Returns `true` if all values are valid, `false` otherwise.
 """
 function check_ac_transmission_rate_values(sys::System)
     is_valid = true
-    base_power = get_base_power(sys)
+    base_power = _get_base_power(sys)
     for line in
         Iterators.flatten((get_components(Line, sys), get_components(MonitoredLine, sys)))
         if !check_rating_values(line, base_power)
@@ -2942,7 +2957,7 @@ end
 
 function handle_component_addition!(sys::System, dyn_injector::DynamicInjection; kwargs...)
     static_injector = kwargs[:static_injector]
-    static_base_power = get_base_power(static_injector)
+    static_base_power = _get_base_power(static_injector)
     set_base_power!(dyn_injector, static_base_power)
     set_dynamic_injector!(static_injector, dyn_injector)
     return
@@ -3261,15 +3276,17 @@ function convert_component!(
     new_type::Type{StandardLoad};
     kwargs...,
 )
+    # Raw device-base values: struct fields are stored in device base (Float64);
+    # we copy the underlying field directly to avoid SU-conversion round-tripping.
     new_load = new_type(;
         name = get_name(old_load),
         available = get_available(old_load),
         bus = get_bus(old_load),
-        base_power = get_base_power(old_load),
-        constant_active_power = get_active_power(old_load),
-        constant_reactive_power = get_reactive_power(old_load),
-        max_constant_active_power = get_max_active_power(old_load),
-        max_constant_reactive_power = get_max_active_power(old_load),
+        base_power = _get_base_power(old_load),
+        constant_active_power = old_load.active_power,
+        constant_reactive_power = old_load.reactive_power,
+        max_constant_active_power = old_load.max_active_power,
+        max_constant_reactive_power = old_load.max_active_power,
         conformity = get_conformity(old_load),
         dynamic_injector = get_dynamic_injector(old_load),
         internal = _copy_internal_for_conversion(old_load),

src/definitions.jl

@@ -573,6 +573,12 @@ const POWER_SYSTEM_STRUCT_DESCRIPTOR_FILE =
 
 const DEFAULT_SYSTEM_FREQUENCY = 60.0
 
+const DEFAULT_BASE_MVA = 100.0
+# Accumulator type for MW-sum helpers in system_checks.jl. Bare `Float64`
+# because unit-aware getters now return bare numbers; the `MW` arg merely
+# selects the unit basis (see `_sum_or_zero`).
+const MW_ACCUMULATOR_TYPE = Float64
+
 const INFINITE_TIME = 1e4
 const START_COST = 1e8
 const INFINITE_COST = 1e8