Absorb operation models from InfrastructureOptimizationModels by luke-kiernan · Pull Request #121 · Sienna-Platform/PowerOperationsModels.jl

luke-kiernan · 2026-05-13T02:27:53Z

Summary

Receive concrete DecisionModel/EmulationModel, their stores, OptimizationProblemOutputs, and operation-model glue methods (read_*, list_*_keys, _check_numerical_bounds, _pre_solve_model_checks) from IOM.
Deduplicate get_problem_type, validate_template, handle_initial_conditions! onto OperationModel{T}.
Pairs with IOM #100. `[sources]` points at IOM branch `lk/move-operation-to-pom`; update to the merged rev once IOM lands.

Test plan

Full `Pkg.test()`: 13109/13110 pass (1 pre-existing broken).
Re-resolve `[sources]` to the merged IOM rev before final merge.

🤖 Generated with Claude Code

Concrete DecisionModel/EmulationModel + stores, OptimizationProblemOutputs, and the operation-model glue methods (read_*, list_*_keys, _check_numerical_bounds, _pre_solve_model_checks) that compose POM-only types now live here. IOM keeps just the abstract interface. Deduplicate get_problem_type, validate_template, handle_initial_conditions! onto OperationModel{T}. Pairs with IOM PR #100. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

This PR migrates operation model implementations and output/storage infrastructure from InfrastructureOptimizationModels (IOM) into PowerOperationsModels (POM), consolidating default DecisionModel / EmulationModel behavior and bringing OptimizationProblemOutputs + model-store logic into this repository.

Changes:

Adds OptimizationProblemOutputs (read/export/serialize helpers) and new Decision/Emulation model store implementations under src/operation/.
Refactors operation-model lifecycle glue (template validation dispatch, numerical-bounds checks, time series cache interface, initial-conditions update helpers) to live in POM.
Updates tests and test dependencies to validate the migrated outputs behavior and updated POM/IOM split.

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
`src/PowerOperationsModels.jl`	Expands imports and include order to accommodate operation-model + outputs/store code moved from IOM.
`src/utils/print.jl`	Adds `show` methods for problem outputs and numerical-bounds types.
`src/operation/decision_model.jl`	Introduces concrete `DecisionModel` + default problem types and lifts shared logic onto `OperationModel`.
`src/operation/emulation_model.jl`	Introduces concrete `EmulationModel` + default problem types and related update/build logic.
`src/operation/decision_model_store.jl`	Adds store implementation for `DecisionModel` outputs.
`src/operation/emulation_model_store.jl`	Adds store implementation for `EmulationModel` outputs (dataset-backed).
`src/operation/store_common.jl`	Adds shared output-writing and export helpers, including path sanitization.
`src/operation/problem_outputs.jl`	Adds constructors building `OptimizationProblemOutputs` from solved models.
`src/operation/optimization_problem_outputs.jl`	Adds `OptimizationProblemOutputs` container + read/export/serialize APIs.
`src/operation/optimization_problem_outputs_export.jl`	Adds export configuration struct for outputs export selection.
`src/operation/optimization_debugging.jl`	Adds helpers to map MOI indices back to constraints/variables.
`src/operation/model_numerical_analysis_utils.jl`	Adds numerical-bounds analysis utilities for constraints/variables.
`src/operation/operation_model_glue.jl`	Adds abstract `OperationModel` glue methods for store reads/listing and pre-solve checks.
`src/operation/template_validation.jl`	Centralizes default/custom `validate_template` dispatch for operation models.
`src/operation/time_series_interface.jl`	Adds cached time series retrieval helpers for Decision/Emulation models.
`src/operation/initial_conditions_update_in_memory_store.jl`	Adds initial-conditions update entrypoint for store-backed ICs.
`Project.toml`	Adds new direct deps (CSV/DataFrames/HDF5/PrettyTables/etc.) and sources pin.
`test/test_optimization_outputs.jl`	New tests for `OptimizationProblemOutputs` timestamp processing, reads, and natural-unit conversion.
`test/test_model_decision.jl`	Updates decision model tests to use POM-exported APIs for outputs/keys/duals/parameters/bounds.
`test/test_utils/mock_operation_models.jl`	Updates mock models to subtype POM default problem types and use moved methods.
`test/test_utils/model_checks.jl`	Updates numerical-bounds test helpers to reference POM bounds types.
`test/Project.toml`	Updates test sources pin to the migration branch of IOM.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

luke-kiernan · 2026-05-13T20:58:18Z

+
+function list_all_keys(x::OperationModel)
+    return Iterators.flatten(
+        list_fields(get_store(x), T) for T in STORE_CONTAINER_TYPES


oh! see this comment: iterating over STORE_CONTAINER_TYPES is better, but yes, then we need to make sure it's in scope (bc it's defined back in IOM)

All 10 CoPilot comments — real bugs in code carried over from IOM: fix undefined `template` reference in EmulationModel constructor (mirror DecisionModel's pattern), add missing `throw()` around an IS.ArgumentError, remove dead empty!/isempty branches that referenced fields DatasetContainer doesn't have, import the missing STORE_CONTAINER_TYPES, correct the undefined `sys_uuid`/`res.source_uuid` in set_source_data!'s error message, swap JSON for JSON3, fix the bare tf_html_simple and stray ISOPT.get_resolution in print.jl, and patch docstring typos. New regression tests caught two more: show(::OptimizationProblemOutputs) referenced an undefined `T` and a missing `outputs.problem` field, and export_optimizer_stats JSON path passed a DataFrame into to_dict which has no method. Also fix the `bonuds` typo in 5 update_numerical_bounds methods and FIXME the dead PSI-leftover should_export_* call paths. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

luke-kiernan

Looking at all definitions of write_output!, doeesn't look like name::Symbol is used anywhere. update_timestamp is only used for the emulation model ones.

luke-kiernan · 2026-05-13T19:52:41Z

+            "The System contains a combination of forecast data and transformed time series data. Currently this is not supported.",
+        )
+    end
+    if "Deterministic" ∈ existing_types


Pre-existing issue: is string matching really the best way to do this? It seems we ought to work with types directly instead...

luke-kiernan · 2026-05-13T19:56:35Z

+    template::AbstractProblemTemplate,
+    sys::IS.InfrastructureSystemsContainer,
+    jump_model::Union{Nothing, JuMP.Model} = nothing;
+    name = nothing,


This is begging for a macro or something similar

luke-kiernan · 2026-05-13T20:01:56Z

+    time_steps_count = get_time_steps(container)[end]
+    initial_time = get_initial_time(container)
+    model_interval = get_interval(params)
+    for type in STORE_CONTAINERS


nitpick: we're iterating over symbols here. Iterating over types (STORE_CONTAINER_TYPES) would be more compilation-friendly, especially if we unroll the loop.

luke-kiernan · 2026-05-13T20:06:19Z

+function write_output!(
+    store::DecisionModelStore,
+    name::Symbol,
+    key::OptimizationContainerKey,


Add type parameter: if key::OptimizationContainerKey{M, <:InfrastructureSystemsType} then we can write container = getfield(store, IOM.field_for_type(M)). Also applies to most of the below write_output! and read_output definitions too.

luke-kiernan · 2026-05-13T20:09:12Z

+    return
+end
+
+function get_current_time(model::EmulationModel)


identical to the DecisionModel definition.

luke-kiernan · 2026-05-13T20:31:31Z

+"""
+Construct OptimizationProblemOutputs from a solved EmulationModel.
+"""
+function OptimizationProblemOutputs(model::EmulationModel)


Basically identical to the DecisionModel version. Consolidate.

luke-kiernan · 2026-05-13T20:32:53Z

+
+# Aliases used for clarity in the method dispatches so it is possible to know if writing to
+# DecisionModel data or EmulationModel data
+# Note: DecisionModelIndexType and EmulationModelIndexType are defined in core/definitions.jl


These constants are defined back in IOM, but only used in POM: move them over.

luke-kiernan · 2026-05-13T20:40:07Z

+    return
+end
+
+function write_model_dual_outputs!(


Again with the "nearly the same thing but with a different optimization key type." See if it can be easily consolidated via multiple dispatch or macro.

luke-kiernan · 2026-05-13T20:42:34Z

+    return TimeSeries.values(ts)
+end
+
+function get_time_series_values!(


Basically the same as DecisionModel. Consolidate?

luke-kiernan · 2026-05-13T20:51:05Z

@@ -0,0 +1,337 @@
+import PowerOperationsModels:


Find a less ad-hoc but still modular way to test this stuff? What's going on in this file seems complex enough to deserve better test cases than these superficial AI-written ones.

luke-kiernan requested a review from Copilot May 13, 2026 02:29

Copilot started reviewing on behalf of luke-kiernan May 13, 2026 02:30 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

luke-kiernan commented May 13, 2026

View reviewed changes

luke-kiernan requested a review from acostarelli May 13, 2026 21:00

bump PNM compat

f6eb4bd

Conversation

luke-kiernan commented May 13, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luke-kiernan May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luke-kiernan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

luke-kiernan May 13, 2026 •

edited

Loading