-
Notifications
You must be signed in to change notification settings - Fork 1
Port hybrid systems #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
acostarelli
wants to merge
17
commits into
main
Choose a base branch
from
ac/hybrid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Port hybrid systems #104
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4ad672f
claude initial
b36ad3c
fix time-series parameter accessing; fix onparameter cost adding
e0d67dc
simplify constructor
e2e7871
formatting
8d93d17
address reviews: add type untyped arguments; support reservation, reg…
a3d2c6b
format
6b827d4
refactor: unify two-sided hybrid+storage methods via trait dispatch
59c994b
refactor: defer hybrid thermal range constraints to IOM helper
5dea6aa
Revert "refactor: defer hybrid thermal range constraints to IOM helper"
379d8c5
docs: rename Bounds → Domain in HybridDispatchWithReserves docstring
353ca8e
refactor: replace isa-on-service with multiple-dispatch helpers
0d43888
restore tests
9dd7ef6
refactor: parametric abstract types collapse paired hybrid reserve fa…
a00df13
formatting
2343c8e
rename abstract types
b962d2b
Merge remote-tracking branch 'origin/main' into ac/hybrid
8a83bce
formatting
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -222,6 +222,18 @@ Parameter to record that the component changed in the availability status | |
| """ | ||
| struct AvailableStatusChangeCountdownParameter <: EventParameter end | ||
|
|
||
| ################################################################################# | ||
| # Hybrid System Parameters | ||
| ################################################################################# | ||
|
|
||
| "Time-series parameter for the maximum active power available from a hybrid system's | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jd-lara This is a change from how things are currently defined in HSS with the time series attached to the hybrid, not the subcomponent, but I guess that works and is simpler for this case? |
||
| renewable subcomponent, normalized by the renewable unit's `max_active_power` rating." | ||
| struct HybridRenewableActivePowerTimeSeriesParameter <: TimeSeriesParameter end | ||
|
|
||
| "Time-series parameter for a hybrid system's electric-load subcomponent demand, | ||
| normalized by the load's `max_active_power`." | ||
| struct HybridElectricLoadTimeSeriesParameter <: TimeSeriesParameter end | ||
|
|
||
| ################################################################################# | ||
| # Method extensions for should_write_resulting_value | ||
| ################################################################################# | ||
|
|
@@ -256,3 +268,6 @@ convert_output_to_natural_units(::Type{EnergyTargetTimeSeriesParameter}) = true | |
| convert_output_to_natural_units(::Type{EnergyBudgetTimeSeriesParameter}) = true | ||
| convert_output_to_natural_units(::Type{InflowTimeSeriesParameter}) = false | ||
| convert_output_to_natural_units(::Type{OutflowTimeSeriesParameter}) = false | ||
| convert_output_to_natural_units(::Type{HybridRenewableActivePowerTimeSeriesParameter}) = | ||
| true | ||
| convert_output_to_natural_units(::Type{HybridElectricLoadTimeSeriesParameter}) = true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.