-
Notifications
You must be signed in to change notification settings - Fork 1
Port hybrid systems #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Port hybrid systems #104
Changes from 17 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
0bf1ff5
Bilinear hydro formulation and IOM/PSY API updates
001b82a
Merge branch 'main' into ac/hydro-bilinear
acostarelli 4ad672f
claude initial
b36ad3c
fix time-series parameter accessing; fix onparameter cost adding
e0d67dc
simplify constructor
e2e7871
formatting
8d93d17
address reviews: add type untyped arguments; support reservation, reg…
a3d2c6b
format
6b827d4
refactor: unify two-sided hybrid+storage methods via trait dispatch
59c994b
refactor: defer hybrid thermal range constraints to IOM helper
5dea6aa
Revert "refactor: defer hybrid thermal range constraints to IOM helper"
379d8c5
docs: rename Bounds → Domain in HybridDispatchWithReserves docstring
353ca8e
refactor: replace isa-on-service with multiple-dispatch helpers
0d43888
restore tests
9dd7ef6
refactor: parametric abstract types collapse paired hybrid reserve fa…
a00df13
formatting
2343c8e
rename abstract types
b962d2b
Merge remote-tracking branch 'origin/main' into ac/hybrid
8a83bce
formatting
f559b20
Merge remote-tracking branch 'origin/main' into ac/hydro-bilinear
9bc4add
Address review comments on bilinear hydro test
a73d189
Rename HydroTurbineBin2BilinearDispatch to MILP and expose bilinear_a…
57bc7ae
switch HydroTurbineMILPBilinearDispatch from n_segments to tolerance
147ec06
Replace bilinear attribute config with POM config structs
b938cbd
Merge remote-tracking branch 'origin/main' into ac/hydro-milp-rename
8363d0b
Simplify bilinear _iom_config bridge against updated IOM contract
f03f49f
Generalize bilinear configs to x×y and validate tolerance
929fa0c
refactor: remove const aliases, use parametric types directly
1d84d0f
reuse PSY.reservedirection
de5735d
Return to attribute-based bilinear config, deriving epigraph depth fr…
b4e1a6c
Merge remote-tracking branch 'origin/main' into ac/hydro-milp-rename
0414f81
update source branches
14dbbfd
removed excessive comments and tests
297007c
remove storage_of helper
e8f7333
Merge remote-tracking branch 'origin/main' into ac/hybrid
ccca499
Make converter loss approximations attribute-driven
475769b
Add relative tolerance to bilinear approximation API
5ebe8f6
Merge NLP+MILP bilinear formulations into single attribute-driven types
3919d47
Address June 8 review: centralize bilinear attrs, tighten tolerance, …
9d930d6
two-layer -> one-layer helper with extra noop for ambiguity
d954775
remove excessive comments and tests
1f3d6f7
copilot review
da98c62
fix target for approximation test
1b1aa08
Fix vacuous HVDC MILP/NLP agreement test
43465c2
remove bad test
44f9cf4
fix a few more reserve traits
4ea83cb
Merge remote-tracking branch 'origin/ac/hydro-milp-rename' into ac/hy…
964a665
formatting
4fded2c
tests run faster; use units in getters
46fdac2
Merge remote-tracking branch 'origin/main' into ac/hybrid
8aa359a
Address PR #104 June-9 review: storage reserve bug, storage-less hybr…
cc7aca5
Fix hybrid energy target: restore surplus/shortage slacks (soft equal…
3f9fa11
formatting
88e44b7
Apply suggestions from code review
acostarelli 09e4a34
Merge branch 'main' into ac/hybrid
jd-lara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.