Update to psy5 and document package by kdayday · Pull Request #37 · Sienna-Platform/HybridSystemsSimulations.jl

kdayday · 2026-02-25T17:13:10Z

Depends on Sienna-Platform/PowerSystems.jl#1660
Depends on Sienna-Platform/PowerSystemCaseBuilder.jl#191 for testing
Closes #38

Summary

This branch upgrades HybridSystemsSimulations.jl for current InfrastructureSystems, PowerSystems, and PowerSimulations stacks (PSY 5–oriented work), tightens hybrid / merchant modeling paths, and refreshes documentation (Diataxis-style layout, tutorial scaffolding, Documenter/formatter updates, doc preview cleanup workflow).

Compatibility & API surface

Bumps dependency bounds in Project.toml / docs/Project.toml and aligns code with newer PSI behavior (e.g. removal of system_to_file usage where needed for PSI compatibility).
Renames Bookkeeping usage to StorageDispatchWithReserves and extends validation / initial-conditions handling so models with reserves behave correctly.
Adds / expands core formulation material (src/core/formulations.jl and related constraints.jl, decision_models.jl, parameters.jl, variables.jl) and wires it through decision models and hybrid device models.
Merchant path: updated thermal fuel / cost handling, a PSI._update_parameter_values! override to keep merchant simulations consistent, and a guard that errors if the merchant model is used without a HybridSystem.
Feedforwards and objective code updated for the new formulation / parameter patterns.
Breaking change typo fix: ComplentarySlacknessCyclingCharge → ComplementarySlacknessCyclingCharge ComplentarySlacknessCyclingDischarge → ComplementarySlacknessCyclingDischarge

Tests

Merchant and hybrid simulation tests updated for PSI/PSY changes; adds coverage around StorageDispatchWithReserves and hybrid templates.
Drops HydroPowerSimulations and StorageSystemsSimulations from the test environment where no longer needed; runtests.jl no longer imports StorageSystemsSimulations.
Simplifies the hybrid simulation test that previously split HybridSystem + EnergyReservoirStorage with StorageDispatchWithReserves into a single HybridEnergyOnlyDispatch-style hybrid configuration with energy_target / reservation attributes (renamed testset for clarity).
Removes obsolete / skipped “x_” test files and redundant price utilities (test/test_utils/price_generation_utils.jl), and trims dead code from test helpers.

Docs & repo hygiene

Substantial docs/make.jl changes plus docs/make_tutorials.jl for tutorial generation.
Adds .github/workflows/doc-preview-cleanup.yml, updates CONTRIBUTING.md, formatter script tweaks, and internal reference .claude/Sienna.md (from IS).
Formulations are documented within type docstrings, rather than separate formulation library

Risk / review focus

Breaking changes for callers still on older PSY/PSI: dependency floor and removed APIs (system_to_file, old bookkeeping naming, merchant without hybrid).
Merchant simulations: confirm fuel/cost data shapes and the _update_parameter_values! override match your production cases.
Docs: preview cleanup workflow and any secrets/permissions for GitHub Actions.

…rves

…n updates

… adder

…SI._update_parameter_values! override to fix merchant sims

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

https://github.com/NREL-Sienna/HybridSystemsSimulations.jl/blob/10fae251cacde55d6ccc9cdc6987e40770fc2eef/test/test_utils/function_utils.jl#L126-L126

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: kdayday <kdayday@users.noreply.github.com>

…ions.jl into kd/psy5

Agent-Logs-Url: https://github.com/Sienna-Platform/HybridSystemsSimulations.jl/sessions/ed090d9d-2ba8-422d-be3d-23f23463db3f Co-authored-by: kdayday <12451220+kdayday@users.noreply.github.com>

…in ext

github-actions · 2026-06-12T19:08:18Z

+1. **Device formulations** — model a `HybridSystem` as one device inside a standard PSI `ProblemTemplate` (e.g., a UC or ED problem), dispatching the hybrid's internal assets subject to PCC limits.
+2. **Merchant decision models** — custom `PSI.DecisionModel`s (with their own `build_impl!`) that optimize a price-taker hybrid's energy and ancillary-service bids against day-ahead (DA) and real-time (RT) market prices, including a bilevel/KKT formulation.


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

1. **Device formulations** — model a `HybridSystem` as one device inside a standard PSI `ProblemTemplate` (e.g., a UC or ED problem), dispatching the hybrid's internal assets subject to PCC limits.

2. **Merchant decision models** — custom `PSI.DecisionModel`s (with their own `build_impl!`) that optimize a price-taker hybrid's energy and ancillary-service bids against day-ahead (DA) and real-time (RT) market prices, including a bilevel/KKT formulation.

1. **Device formulations** — model a `HybridSystem` as one device inside a standard PSI `ProblemTemplate` (e.g., a UC or ED problem), dispatching the hybrid's internal assets subject to PCC limits.

2. **Merchant decision models** — custom `PSI.DecisionModel`s (with their own `build_impl!`) that optimize a price-taker hybrid's energy and ancillary-service bids against day-ahead (DA) and real-time (RT) market prices, including a bilevel/KKT formulation.

github-actions · 2026-06-12T19:08:18Z

+| Formulation | Description |
+|---|---|
+| `HybridEnergyOnlyDispatch` | Energy-only dispatch of the hybrid's internal assets behind the PCC |


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

| Formulation | Description |

|---|---|

| `HybridEnergyOnlyDispatch` | Energy-only dispatch of the hybrid's internal assets behind the PCC |

| Formulation | Description |

|:---------------------------- |:--------------------------------------------------------------------------------------------------- |

| `HybridEnergyOnlyDispatch` | Energy-only dispatch of the hybrid's internal assets behind the PCC |

github-actions · 2026-06-12T19:08:19Z

+|---|---|
+| `HybridEnergyOnlyDispatch` | Energy-only dispatch of the hybrid's internal assets behind the PCC |
+| `HybridDispatchWithReserves` | Dispatch with ancillary-service participation, reserve assignment, and reserve coverage constraints |
+| `HybridFixedDA` | Hybrid with fixed day-ahead positions (used downstream of a merchant stage) |


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

| `HybridFixedDA` | Hybrid with fixed day-ahead positions (used downstream of a merchant stage) |

| `HybridFixedDA` | Hybrid with fixed day-ahead positions (used downstream of a merchant stage) |

github-actions · 2026-06-12T19:08:19Z

+| Decision model | Description |
+|---|---|
+| `MerchantHybridEnergyCase` | DA + RT energy-only bid co-optimization |
+| `MerchantHybridEnergyFixedDA` | RT subproblem with locked DA bids |
+| `MerchantHybridCooptimizerCase` | DA + RT energy and ancillary-service bid co-optimization |
+| `MerchantHybridBilevelCase` | Bilevel formulation (KKT conditions + complementary slackness via SOS1, strong duality) |


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

| Decision model | Description |

|---|---|

| `MerchantHybridEnergyCase` | DA + RT energy-only bid co-optimization |

| `MerchantHybridEnergyFixedDA` | RT subproblem with locked DA bids |

| `MerchantHybridCooptimizerCase` | DA + RT energy and ancillary-service bid co-optimization |

| `MerchantHybridBilevelCase` | Bilevel formulation (KKT conditions + complementary slackness via SOS1, strong duality) |

| Decision model | Description |

|:------------------------------- |:--------------------------------------------------------------------------------------- |

| `MerchantHybridEnergyCase` | DA + RT energy-only bid co-optimization |

| `MerchantHybridEnergyFixedDA` | RT subproblem with locked DA bids |

| `MerchantHybridCooptimizerCase` | DA + RT energy and ancillary-service bid co-optimization |

| `MerchantHybridBilevelCase` | Bilevel formulation (KKT conditions + complementary slackness via SOS1, strong duality) |

github-actions · 2026-06-12T19:08:19Z

+- **DA bids are hourly slots; RT variables follow the model resolution.** The DA axis is `merchant_da_time_step_range(container, hybrid)` = `1:min(horizon_hours, DA-series length)`; the variable, parameter, constraint, and objective axes must all use it. RT-to-DA index mapping goes through `merchant_rt_to_da_tmap(rt_len, da_len)` — never hand-roll `div`-based maps.
+- **Storage energy quantities are in energy units**, computed as `get_storage_level_limits(storage).{min,max} * get_storage_capacity(storage)`. The same convention applies to initial conditions (`get_initial_storage_capacity_level * capacity`), cycling limits, and `storage_target`. Do not use the bare level fractions.
+- **Market prices are hybrid-attached scalar `SingleTimeSeries`**, keyed by name (defaults `"DA"`/`"RT"`, override via `model.ext["day_ahead_time_series_key"]` / `"real_time_time_series_key"`):
+  - Energy: `hybrid_energy_price_time_series_name(key)` → `"HybridSystem__energy_price__<key>"`
+  - Ancillary: `hybrid_ancillary_service_price_time_series_name(service, key)`
+  - Profiles: `"RenewableDispatch__max_active_power"`, `"PowerLoad__max_active_power"`
+- `Δt_RT` must come from the container/settings resolution (`PSI.get_resolution`), not from `first(PSY.get_time_series_resolutions(sys))` — systems may carry multiple resolutions and `PSI.validate_time_series!` negotiates the selected one into settings.


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

- **DA bids are hourly slots; RT variables follow the model resolution.** The DA axis is `merchant_da_time_step_range(container, hybrid)` = `1:min(horizon_hours, DA-series length)`; the variable, parameter, constraint, and objective axes must all use it. RT-to-DA index mapping goes through `merchant_rt_to_da_tmap(rt_len, da_len)` — never hand-roll `div`-based maps.

- **Storage energy quantities are in energy units**, computed as `get_storage_level_limits(storage).{min,max} * get_storage_capacity(storage)`. The same convention applies to initial conditions (`get_initial_storage_capacity_level * capacity`), cycling limits, and `storage_target`. Do not use the bare level fractions.

- **Market prices are hybrid-attached scalar `SingleTimeSeries`**, keyed by name (defaults `"DA"`/`"RT"`, override via `model.ext["day_ahead_time_series_key"]` / `"real_time_time_series_key"`):

- Energy: `hybrid_energy_price_time_series_name(key)` → `"HybridSystem__energy_price__<key>"`

- Ancillary: `hybrid_ancillary_service_price_time_series_name(service, key)`

- Profiles: `"RenewableDispatch__max_active_power"`, `"PowerLoad__max_active_power"`

- `Δt_RT` must come from the container/settings resolution (`PSI.get_resolution`), not from `first(PSY.get_time_series_resolutions(sys))` — systems may carry multiple resolutions and `PSI.validate_time_series!` negotiates the selected one into settings.

- **DA bids are hourly slots; RT variables follow the model resolution.** The DA axis is `merchant_da_time_step_range(container, hybrid)` = `1:min(horizon_hours, DA-series length)`; the variable, parameter, constraint, and objective axes must all use it. RT-to-DA index mapping goes through `merchant_rt_to_da_tmap(rt_len, da_len)` — never hand-roll `div`-based maps.

- **Storage energy quantities are in energy units**, computed as `get_storage_level_limits(storage).{min,max} * get_storage_capacity(storage)`. The same convention applies to initial conditions (`get_initial_storage_capacity_level * capacity`), cycling limits, and `storage_target`. Do not use the bare level fractions.

- **Market prices are hybrid-attached scalar `SingleTimeSeries`**, keyed by name (defaults `"DA"`/`"RT"`, override via `model.ext["day_ahead_time_series_key"]` / `"real_time_time_series_key"`):

+ Energy: `hybrid_energy_price_time_series_name(key)` → `"HybridSystem__energy_price__<key>"`

+ Ancillary: `hybrid_ancillary_service_price_time_series_name(service, key)`

+ Profiles: `"RenewableDispatch__max_active_power"`, `"PowerLoad__max_active_power"`

- `Δt_RT` must come from the container/settings resolution (`PSI.get_resolution`), not from `first(PSY.get_time_series_resolutions(sys))` — systems may carry multiple resolutions and `PSI.validate_time_series!` negotiates the selected one into settings.

github-actions · 2026-06-12T19:08:19Z

+- **Custom variables**: market bids (`EnergyDABidOut/In`, `EnergyRTBidOut/In`, `BidReserveVariableOut/In`), internal asset variables (`ThermalPower`, `RenewablePower`, `BatteryCharge/Discharge`, `BatteryStatus`), reserves (`TotalReserve`, slacks), and bilevel dual/complementarity variables (`λ`, `μ`, `γ`, `κ`, `ν` families).
+- **Custom parameters**: `DayAheadEnergyPrice`, `RealTimeEnergyPrice`, `AncillaryServicePrice`, `CyclingCharge/DischargeLimitParameter`.
+- **Feedforwards**: `CyclingChargeLimitFeedforward`, `CyclingDischargeLimitFeedforward` for DA→RT cycling budget coupling.
+- **PSI internal overrides** (sensitive to PSI version changes — re-verify on every PSI bump):
+  - `PSI.update_decision_state!` for DA bid and reserve variable state (DA bids span one hour of state rows each; all methods clamp to `max_state_index`).
+  - `PSI._update_parameter_values!` for hybrid profile/price updates during simulation (guarded by `PSI.get_component_names(attributes)`).
+  - `PSI._constituent_cost_expression(::DayAheadEnergyPrice)` — required by PSI's generic `update_variable_cost!`; without it, merchant simulations fail at the first parameter update (not at build).
+  - `PSI.validate_time_series!` for `HybridDecisionProblem` (multi-resolution and interval negotiation).
+- **Catch discipline**: time-series lookups only swallow `ArgumentError` (`e isa ArgumentError || rethrow()`); container probes use `PSI.has_container_key`, never try/catch.


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

- **Custom variables**: market bids (`EnergyDABidOut/In`, `EnergyRTBidOut/In`, `BidReserveVariableOut/In`), internal asset variables (`ThermalPower`, `RenewablePower`, `BatteryCharge/Discharge`, `BatteryStatus`), reserves (`TotalReserve`, slacks), and bilevel dual/complementarity variables (`λ`, `μ`, `γ`, `κ`, `ν` families).

- **Custom parameters**: `DayAheadEnergyPrice`, `RealTimeEnergyPrice`, `AncillaryServicePrice`, `CyclingCharge/DischargeLimitParameter`.

- **Feedforwards**: `CyclingChargeLimitFeedforward`, `CyclingDischargeLimitFeedforward` for DA→RT cycling budget coupling.

- **PSI internal overrides** (sensitive to PSI version changes — re-verify on every PSI bump):

- `PSI.update_decision_state!` for DA bid and reserve variable state (DA bids span one hour of state rows each; all methods clamp to `max_state_index`).

- `PSI._update_parameter_values!` for hybrid profile/price updates during simulation (guarded by `PSI.get_component_names(attributes)`).

- `PSI._constituent_cost_expression(::DayAheadEnergyPrice)` — required by PSI's generic `update_variable_cost!`; without it, merchant simulations fail at the first parameter update (not at build).

- `PSI.validate_time_series!` for `HybridDecisionProblem` (multi-resolution and interval negotiation).

- **Catch discipline**: time-series lookups only swallow `ArgumentError` (`e isa ArgumentError || rethrow()`); container probes use `PSI.has_container_key`, never try/catch.

- **Custom variables**: market bids (`EnergyDABidOut/In`, `EnergyRTBidOut/In`, `BidReserveVariableOut/In`), internal asset variables (`ThermalPower`, `RenewablePower`, `BatteryCharge/Discharge`, `BatteryStatus`), reserves (`TotalReserve`, slacks), and bilevel dual/complementarity variables (`λ`, `μ`, `γ`, `κ`, `ν` families).

- **Custom parameters**: `DayAheadEnergyPrice`, `RealTimeEnergyPrice`, `AncillaryServicePrice`, `CyclingCharge/DischargeLimitParameter`.

- **Feedforwards**: `CyclingChargeLimitFeedforward`, `CyclingDischargeLimitFeedforward` for DA→RT cycling budget coupling.

- **PSI internal overrides** (sensitive to PSI version changes — re-verify on every PSI bump):

+ `PSI.update_decision_state!` for DA bid and reserve variable state (DA bids span one hour of state rows each; all methods clamp to `max_state_index`).

+ `PSI._update_parameter_values!` for hybrid profile/price updates during simulation (guarded by `PSI.get_component_names(attributes)`).

+ `PSI._constituent_cost_expression(::DayAheadEnergyPrice)` — required by PSI's generic `update_variable_cost!`; without it, merchant simulations fail at the first parameter update (not at build).

+ `PSI.validate_time_series!` for `HybridDecisionProblem` (multi-resolution and interval negotiation).

- **Catch discipline**: time-series lookups only swallow `ArgumentError` (`e isa ArgumentError || rethrow()`); container probes use `PSI.has_container_key`, never try/catch.

github-actions · 2026-06-12T19:08:19Z

+- Requires PowerSystems 5.x and PowerSimulations 0.36.2+ (`~0.36.2` compat deliberately excludes PSI 0.36.0/0.36.1, which are broken for PowerModels-translated networks with parallel branches — `get_equivalent_physical_branch_parameters` MethodError against PNM 0.23).
+- Storage cost access must use PSY5 accessors: `get_charge_variable_cost` / `get_discharge_variable_cost` → `get_vom_cost` → `get_proportional_term`. `StorageCost` has no `variable` field.


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

- Requires PowerSystems 5.x and PowerSimulations 0.36.2+ (`~0.36.2` compat deliberately excludes PSI 0.36.0/0.36.1, which are broken for PowerModels-translated networks with parallel branches — `get_equivalent_physical_branch_parameters` MethodError against PNM 0.23).

- Storage cost access must use PSY5 accessors: `get_charge_variable_cost` / `get_discharge_variable_cost` → `get_vom_cost` → `get_proportional_term`. `StorageCost` has no `variable` field.

- Requires PowerSystems 5.x and PowerSimulations 0.36.2+ (`~0.36.2` compat deliberately excludes PSI 0.36.0/0.36.1, which are broken for PowerModels-translated networks with parallel branches — `get_equivalent_physical_branch_parameters` MethodError against PNM 0.23).

- Storage cost access must use PSY5 accessors: `get_charge_variable_cost` / `get_discharge_variable_cost` → `get_vom_cost` → `get_proportional_term`. `StorageCost` has no `variable` field.

github-actions · 2026-06-12T19:08:19Z

+- Run with `julia --project=test test/runtests.jl` (single testset: append the test file basename, e.g. `test_merchant_sequence`). See Sienna.md for the full test-environment conventions.
+- Test systems come from PowerSystemCaseBuilder (RTS GMLC); market price fixtures are the `test/inputs/chuhsi_*` CSVs (hourly, 5-min, and 300/864-step variants). `attach_hybrid_market_time_series!` in `test/test_utils/function_utils.jl` is the single entry point for attaching them — `use_rt_resolution_for_da` switches between hourly-DA and RT-resolution-DA price setups, and both paths must stay covered.
+- Merchant tests assert hourly DA axes (e.g., 24 DA bids vs 288 RT bids for a 24 h / 5 min model). Always assert `build!`/`solve!`/`execute!` return statuses, not just result shapes.
+- Known modeling caveat: pinning a downstream UC's PCC variables to merchant DA bids via `FixValueFeedforward` is structurally infeasible while merchant DA buy/sell positions can overlap in the same hour (UC's reservation constraint forbids simultaneous in/out). See the note in `test/test_merchant_sequence.jl`.


[JuliaFormatter] _{reported by reviewdog 🐶}

Suggested change

- Run with `julia --project=test test/runtests.jl` (single testset: append the test file basename, e.g. `test_merchant_sequence`). See Sienna.md for the full test-environment conventions.

- Test systems come from PowerSystemCaseBuilder (RTS GMLC); market price fixtures are the `test/inputs/chuhsi_*` CSVs (hourly, 5-min, and 300/864-step variants). `attach_hybrid_market_time_series!` in `test/test_utils/function_utils.jl` is the single entry point for attaching them — `use_rt_resolution_for_da` switches between hourly-DA and RT-resolution-DA price setups, and both paths must stay covered.

- Merchant tests assert hourly DA axes (e.g., 24 DA bids vs 288 RT bids for a 24 h / 5 min model). Always assert `build!`/`solve!`/`execute!` return statuses, not just result shapes.

- Known modeling caveat: pinning a downstream UC's PCC variables to merchant DA bids via `FixValueFeedforward` is structurally infeasible while merchant DA buy/sell positions can overlap in the same hour (UC's reservation constraint forbids simultaneous in/out). See the note in `test/test_merchant_sequence.jl`.

- Run with `julia --project=test test/runtests.jl` (single testset: append the test file basename, e.g. `test_merchant_sequence`). See Sienna.md for the full test-environment conventions.

- Test systems come from PowerSystemCaseBuilder (RTS GMLC); market price fixtures are the `test/inputs/chuhsi_*` CSVs (hourly, 5-min, and 300/864-step variants). `attach_hybrid_market_time_series!` in `test/test_utils/function_utils.jl` is the single entry point for attaching them — `use_rt_resolution_for_da` switches between hourly-DA and RT-resolution-DA price setups, and both paths must stay covered.

- Merchant tests assert hourly DA axes (e.g., 24 DA bids vs 288 RT bids for a 24 h / 5 min model). Always assert `build!`/`solve!`/`execute!` return statuses, not just result shapes.

- Known modeling caveat: pinning a downstream UC's PCC variables to merchant DA bids via `FixValueFeedforward` is structurally infeasible while merchant DA buy/sell positions can overlap in the same hour (UC's reservation constraint forbids simultaneous in/out). See the note in `test/test_merchant_sequence.jl`.

kdayday added 21 commits February 18, 2026 21:13

Update documenter and formatter and add docstrings

d4547f6

Run formatter

dbbbf30

Add formulations and add and clean docstrings

b3e2715

Fix Complentary typo

3d2c013

Diataxis and add tutorial infrastructure

0f4bc23

Add docs cleanup github action

4da239a

Draft psy5 updates

07becfb

Specify initial conditions model to avoid errors for models with rese…

aa84db4

…rves

Extend validate_time_series

b0f253f

Add StorageDispatchWithReserves tests and update tests for PSI versio…

4f24490

…n updates

Bookkeeping -> StorageDispatchWithReserves

46e7513

IS, PSY, PSI, comment version updates

4bfb4ca

Update input data in docstrings

46fc2da

Clean up extrefs and simplify

f2cc7bf

Error if merchant model called without HybridSystem

dd8d78d

Remove redundant price utils, bug fixes, and in-progress day ahead ts…

3434602

… adder

Remove dead code from test utils

6ee4d2f

Remove system_to_file for PSI compat

143fe9f

Update merchant thermal costs for new fuel and cost formats and add P…

43925ec

…SI._update_parameter_values! override to fix merchant sims

Add Sienna.md from IS

323b743

Remove docs todo

9561ffd

kdayday mentioned this pull request Apr 16, 2026

Fill out documentation #36

Closed

1 task

kdayday changed the title ~~[WIP] Update to psy5~~ [WIP] Update to psy5 and document package Apr 16, 2026

Remove HPS and SSS from test dependencies and remove dead test code

10fae25

github-actions Bot reviewed Apr 16, 2026

View reviewed changes

kdayday added 3 commits April 17, 2026 09:02

Formatter

bcf63c7

Add pre-commit yaml

8223583

Docstring parameter clarifications and clean-up

fee3a79

kdayday changed the title ~~[WIP] Update to psy5 and document package~~ Update to psy5 and document package Apr 17, 2026

kdayday marked this pull request as ready for review April 17, 2026 16:43

kdayday commented Apr 17, 2026

View reviewed changes

Comment thread test/test_utils/function_utils.jl Outdated

kdayday and others added 6 commits April 17, 2026 17:41

Apply suggestions from code review

35138d7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: kdayday <kdayday@users.noreply.github.com>

Apply literate changes from PF PR

94c1570

Merge branch 'kd/psy5' of github.com:NREL-Sienna/HybridSystemsSimulat…

7aa1f50

…ions.jl into kd/psy5

Merge branch 'main' into kd/psy5

e6bbb58

Skip cleanup on forks

6aa810e

Replace remaining nrel-sienna links

720598f

Copilot started work on behalf of kdayday April 30, 2026 21:19 View session

Fix bare catch blocks in _add_hybrid_renewable_da_time_series!

d8fd3d2

Agent-Logs-Url: https://github.com/Sienna-Platform/HybridSystemsSimulations.jl/sessions/ed090d9d-2ba8-422d-be3d-23f23463db3f Co-authored-by: kdayday <12451220+kdayday@users.noreply.github.com>

Copilot finished work on behalf of kdayday April 30, 2026 21:23

kdayday and others added 15 commits May 1, 2026 13:14

Fix interval horizon issues for PSI 0.34

fb759f1

Harden hybrid time series parameter naming for PSI 0.34

adf7b82

Update for directly attached multi-resolution time-series instead of …

24f8ab2

…in ext

Fix docs links

345183f

Fix extref

6ab0ab6

PSI 0.35 compat and update cost definitions

2833d5b

bump dependencies

12ae686

code correctness updates

5cc977f

update the cycle ff

bf1dcb9

fix some docstrings

e31c320

fix some modeling errors

aaf326f

fix objective function implementation

f6046f8

update decision models

4cbe769

improve testing

130a883

fix deps

860a051

jd-lara approved these changes Jun 12, 2026

View reviewed changes

add the claude.md file

732cf1a

jd-lara merged commit 62a6288 into main Jun 12, 2026
1 of 5 checks passed

jd-lara deleted the kd/psy5 branch June 12, 2026 19:07

github-actions Bot reviewed Jun 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to psy5 and document package#37

Update to psy5 and document package#37
jd-lara merged 48 commits into
mainfrom
kd/psy5

kdayday commented Feb 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot Jun 12, 2026

Uh oh!

github-actions Bot Jun 12, 2026

Uh oh!

github-actions Bot Jun 12, 2026

Uh oh!

github-actions Bot Jun 12, 2026

Uh oh!

github-actions Bot Jun 12, 2026

Uh oh!

github-actions Bot Jun 12, 2026

Uh oh!

github-actions Bot Jun 12, 2026

Uh oh!

github-actions Bot Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		1. Device formulations — model a `HybridSystem` as one device inside a standard PSI `ProblemTemplate` (e.g., a UC or ED problem), dispatching the hybrid's internal assets subject to PCC limits.
		2. Merchant decision models — custom `PSI.DecisionModel`s (with their own `build_impl!`) that optimize a price-taker hybrid's energy and ancillary-service bids against day-ahead (DA) and real-time (RT) market prices, including a bilevel/KKT formulation.

	\| `HybridFixedDA` \| Hybrid with fixed day-ahead positions (used downstream of a merchant stage) \|
	\| `HybridFixedDA` \| Hybrid with fixed day-ahead positions (used downstream of a merchant stage) \|

		- Requires PowerSystems 5.x and PowerSimulations 0.36.2+ (`~0.36.2` compat deliberately excludes PSI 0.36.0/0.36.1, which are broken for PowerModels-translated networks with parallel branches — `get_equivalent_physical_branch_parameters` MethodError against PNM 0.23).
		- Storage cost access must use PSY5 accessors: `get_charge_variable_cost` / `get_discharge_variable_cost` → `get_vom_cost` → `get_proportional_term`. `StorageCost` has no `variable` field.

Conversation

kdayday commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Risk / review focus

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kdayday commented Feb 25, 2026 •

edited

Loading