ci: modernise GitHub Actions versions and add fork-friendly guards#59
Open
ndandan wants to merge 1 commit into
Open
ci: modernise GitHub Actions versions and add fork-friendly guards#59ndandan wants to merge 1 commit into
ndandan wants to merge 1 commit into
Conversation
Bump the pinned actions to current majors (checkout@v5, setup-qemu@v4, setup-buildx@v4, login@v4, metadata@v6, build-push@v7, dockerhub-description@v5, action-gh-release@v3) across ci/beta/release/ dockerhub-readme so builds keep running as older majors are deprecated. Add a workflow_dispatch trigger to ci.yml so the check suite can be run on demand, and guard the Docker Hub README sync job with `if: github.repository == 'Shoshuo/Prismarr'` so forks (which lack the DOCKERHUB_* secrets) skip it instead of failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Modernise the GitHub Actions workflows so builds keep running as older action majors are deprecated, plus two small fork-friendliness fixes.
Action version bumps (across
ci,beta,release,dockerhub-readme)actions/checkoutv4 → v5docker/setup-qemu-actionv3 → v4docker/setup-buildx-actionv3 → v4docker/login-actionv3 → v4docker/metadata-actionv5 → v6docker/build-push-actionv6 → v7peter-evans/dockerhub-descriptionv4 → v5softprops/action-gh-releasev2 → v3Behavioural tweaks
ci.yml— added aworkflow_dispatchtrigger so the check suite can be re-run on demand from the Actions tab (handy when a flake needs a re-run without an empty commit).dockerhub-readme.yml— guarded the sync job withif: github.repository == 'Shoshuo/Prismarr'. Forks don't hold theDOCKERHUB_*secrets, so a README change there currently leaves a red ✗ on a missing-secret failure; the guard makes the job a clean no-op on forks while remaining unconditionally active on the canonical repo.Why
Routine maintenance — pinned actions go stale and start emitting deprecation warnings (and eventually stop running). The fork guard is a courtesy so anyone tracking the repo doesn't get spurious red checks.
Definition of Done
make checksuite is unchanged and green (verified on a PR run of the updatedci.yml).CHANGELOG.mdupdated under[Unreleased] → Contributor.