Use X-API-Key in Gluetun client and remove non-existing WireGuard endpoints#53
Open
Rehpotsirhc-z wants to merge 1 commit into
Open
Use X-API-Key in Gluetun client and remove non-existing WireGuard endpoints#53Rehpotsirhc-z wants to merge 1 commit into
Rehpotsirhc-z wants to merge 1 commit into
Conversation
The Gluetun client authenticated with `Authorization: Bearer <key>`, but Gluetun reads the API key from the `X-API-Key` header. Thus the VPN card only worked when there was no key. Removed the `/v1/wireguard/status` and `/v1/wireguard/portforwarded` endpoints, which do not exist. The now-redundant Gluetun protocol selector is removed from the setup wizard and settings page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Gluetun client authenticated with
Authorization: Bearer <key>, but Gluetun reads the API key from theX-API-Keyheader. Thus, the VPN card only worked when there was no key.Also removed the
/v1/wireguard/statusand/v1/wireguard/portforwardedendpoints, which do not exist. The WireGuard and OpenVPN were both underneath the/v1/openvpnendpoint in the older versions. Since they were both under one endpoint anyway, the protocol selector is redundant and was removed.Type of change
Definition of Done checklist
See
CONTRIBUTING.mdfor the full list.console.log,dd(),var_dump,TODO,FIXMEleftovermake checkpasses locallyCHANGELOG.mdupdated under[Unreleased]README.mdupdated if user-facing behaviour changed (N/A)Notes for the reviewer