changed value of sessionExpiration to 0 instead of null #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etExpires is false
…ull_to_expire_in_setcookie
Contributor
Author
|
I have signed the CLA! |
…ull_to_expire_in_setcookie
…ull_to_expire_in_setcookie
…ull_to_expire_in_setcookie
Contributor
|
hey @da-mask, thanks for the PR! could you please update the tests as well? 🙏 |
Contributor
Author
|
@Arkham Wow, I gave up on this a long time ago, I forgot about it. I don't even work with Shopify anymore. I think I've done the required update. |
Arkham
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #291
WHAT is this pull request doing?
Type of change
Checklist