Error occuring on authentication of non embeded app

[julesbl]

When using the package for OAuth of an offline/not embedded app, the function OAUTH::callback() attempts to use setcookie() with a null value for expires: parameter.

The same issue was raised here
#291
This issue is still extant as the pull request failed, I made the changes indicated and it works, however if I update my version I will be back to a fail again.

[matteodepalo]

Hi @julesbl, just to clarify, you made the changes in this PR and it worked?

[julesbl]

Hi Yes, that is correct, I changed the null to zero and the whole thing sprang to life. Jules

…

On Tue, 29 Oct 2024, 10:18 Matteo Depalo, ***@***.***> wrote: Hi @julesbl <https://github.com/julesbl>, just to clarify, you made the changes in this PR <#293> and it worked? — Reply to this email directly, view it on GitHub <#375 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANGHN2SEHVIAUZ22TRPN4DZ55OHNAVCNFSM6AAAAABPXD5IR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBTHAYDONJTGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[sammyteahan]

I just wanted to jump in and mention I'm facing the same error and applying the fix in PR #293 resolves the issue for me.

[sammyteahan]

For posterity, you can side-step this issue for now by providing your own function to setCookieFunction when using OAuth::begin and OAuth::callback. Ensure you handle setting the expiration value of the cookie with the value you expect, or 0 (instead of null).

Example

function buildAppAuthUrl(string $storeDomain)
{
    $shopifyOAuthCookie = new ShopifyOAuthCookie();
    $cookieFunction = [$shopifyOAuthCookie, 'set'];

    return OAuth::begin(
        isOnline: false,
        shop: $shopDomain,
        redirectPath: '/shopify/auth/callback',
        setCookieFunction: $cookieFunction,
    );
}

class ShopifyOAuthCookie
{
    public static function set(OAuthCookie $cookie): bool
    {
        return setcookie(
            $cookie->getName(),
            $cookie->getValue(),
            $cookie->getExpire() ?? 0,
            "",
            "",
            $cookie->isSecure(),
            $cookie->isHttpOnly(),
        );
    }
}

[lizkenyon]

Resolved with this PR.